Skip to content

Only run trampoline checks in CI when trampolines change #17386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zanieb merged 2 commits into from
Jan 12, 2026
Merged

Only run trampoline checks in CI when trampolines change #17386

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
669e9ee
Only run trampoline checks in CI when trampolines change
claude Jan 9, 2026
87235ac
Remove unnecessary early break optimization
claude Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ jobs:
code: ${{ steps.changed.outputs.code_any_changed }}
# Flag that is raised when uv.schema.json is changed (e.g., in a release PR)
schema: ${{ steps.changed.outputs.schema_changed }}
# Flag that is raised when trampoline-related code is changed
trampoline: ${{ steps.changed.outputs.trampoline_any_changed }}
steps:
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
with:
Expand All @@ -43,6 +45,7 @@ jobs:

CODE_CHANGED=false
SCHEMA_CHANGED=false
TRAMPOLINE_CHANGED=false

while IFS= read -r file; do
# Check if the schema file changed (e.g., in a release PR)
Expand All @@ -51,6 +54,12 @@ jobs:
SCHEMA_CHANGED=true
fi

# Check if trampoline-related files changed
if [[ "${file}" =~ ^crates/uv-trampoline/ ]] || [[ "${file}" =~ ^crates/uv-trampoline-builder/ ]]; then
echo "Detected trampoline change: ${file}"
TRAMPOLINE_CHANGED=true
fi

if [[ "${file}" =~ ^docs/ ]]; then
echo "Skipping ${file} (matches docs/ pattern)"
continue
Expand All @@ -74,11 +83,11 @@ jobs:

echo "Detected code change in: ${file}"
CODE_CHANGED=true
break

done <<< "${CHANGED_FILES}"
echo "code_any_changed=${CODE_CHANGED}" >> "${GITHUB_OUTPUT}"
echo "schema_changed=${SCHEMA_CHANGED}" >> "${GITHUB_OUTPUT}"
echo "trampoline_any_changed=${TRAMPOLINE_CHANGED}" >> "${GITHUB_OUTPUT}"
lint:
timeout-minutes: 10
name: "lint"
Expand Down Expand Up @@ -400,7 +409,7 @@ jobs:
windows-trampoline-check:
timeout-minutes: 15
needs: determine_changes
if: ${{ !contains(github.event.pull_request.labels.*.name, 'no-test') && (needs.determine_changes.outputs.code == 'true' || github.ref == 'refs/heads/main') }}
if: ${{ !contains(github.event.pull_request.labels.*.name, 'no-test') && (needs.determine_changes.outputs.trampoline == 'true' || github.ref == 'refs/heads/main') }}
runs-on: windows-latest
name: "check windows trampoline | ${{ matrix.target-arch }}"
strategy:
Expand Down Expand Up @@ -460,7 +469,7 @@ jobs:
windows-trampoline-test:
timeout-minutes: 10
needs: determine_changes
if: ${{ !contains(github.event.pull_request.labels.*.name, 'no-test') && (needs.determine_changes.outputs.code == 'true' || github.ref == 'refs/heads/main') }}
if: ${{ !contains(github.event.pull_request.labels.*.name, 'no-test') && (needs.determine_changes.outputs.trampoline == 'true' || github.ref == 'refs/heads/main') }}
runs-on: ${{ matrix.runner }}
name: "test windows trampoline | ${{ matrix.target-arch }}"
strategy:
Expand Down
Loading