Only run trampoline checks in CI when trampolines change#17386
Merged
zanieb merged 2 commits intoastral-sh:mainfrom Jan 12, 2026
Merged
Only run trampoline checks in CI when trampolines change#17386zanieb merged 2 commits intoastral-sh:mainfrom
zanieb merged 2 commits intoastral-sh:mainfrom
Conversation
Add a new `trampoline` output to the `determine_changes` job that detects changes in `crates/uv-trampoline/` or `crates/uv-trampoline-builder/`. Update both `windows-trampoline-check` and `windows-trampoline-test` jobs to only run when trampoline-related files are modified (or on main branch), instead of running on every code change. This avoids unnecessary Windows CI runs when non-trampoline code changes.
The conditional break saved at most ~100ms per CI run, which isn't worth the added complexity. Simplify by always iterating through all changed files.
konstin
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to avoid wasting CI time.