Skip to content

fix: add Win32_Storage_FileSystem feature and improve handle closing logic #17374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zanieb merged 2 commits into from
Jan 10, 2026
+5 −0
Merged

fix: add Win32_Storage_FileSystem feature and improve handle closing logic #17374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
690f0b8
fix: add Win32_Storage_FileSystem feature and improve handle closing …
zelosleone Jan 9, 2026
2fd2544
format
zelosleone Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/uv-trampoline/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ windows = { version = "0.61.0", features = [
"Win32_System_LibraryLoader",
"Win32_System_Threading",
"Win32_UI_WindowsAndMessaging",
"Win32_Storage_FileSystem",
] }
ufmt-write = "0.1.0"
ufmt = { version = "0.2.0", features = ["std"] }
Expand Down
4 changes: 4 additions & 0 deletions crates/uv-trampoline/src/bounce.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ use windows::Win32::{
Foundation::{
CloseHandle, HANDLE, HANDLE_FLAG_INHERIT, INVALID_HANDLE_VALUE, SetHandleInformation, TRUE,
},
Storage::FileSystem::{FILE_TYPE_PIPE, GetFileType},
System::Console::{
GetStdHandle, STD_INPUT_HANDLE, STD_OUTPUT_HANDLE, SetConsoleCtrlHandler, SetStdHandle,
},
Expand Down Expand Up @@ -345,6 +346,9 @@ fn close_handles(si: &STARTUPINFOA) {
// Unlike cleanup_standard_io(), we don't close STD_ERROR_HANDLE to retain warn!
for std_handle in [STD_INPUT_HANDLE, STD_OUTPUT_HANDLE] {
if let Ok(handle) = unsafe { GetStdHandle(std_handle) } {
if handle.is_invalid() || unsafe { GetFileType(handle) } != FILE_TYPE_PIPE {
continue;
}
unsafe { CloseHandle(handle) }.unwrap_or_else(|_| {
warn!("Failed to close standard device handle {}", handle.0 as u32);
});
Expand Down
Loading