Use Cow<str> for deserialization everywhere#17330
Merged
Conversation
Signed-off-by: William Woodruff <william@astral.sh>
woodruffw
added
performance
woodruffw
had a problem deploying
to
uv-test-registries
GitHub Actions
Failure
Signed-off-by: William Woodruff <william@astral.sh>
woodruffw
had a problem deploying
to
uv-test-registries
GitHub Actions
Failure
Signed-off-by: William Woodruff <william@astral.sh>
woodruffw
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
Signed-off-by: William Woodruff <william@astral.sh>
woodruffw
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
Signed-off-by: William Woodruff <william@astral.sh>
woodruffw
temporarily deployed
to
uv-test-registries
GitHub Actions
Inactive
| let normalized = PackageName::from_str(&given).map_err(serde::de::Error::custom)?; | ||
| Ok(Self { given, normalized }) | ||
| Ok(Self { | ||
| given: given.to_string(), |
Member
There was a problem hiding this comment.
This seems marginal since we allocate anyway? (Maybe we should use ArcStr for the given name.)
Member
Author
There was a problem hiding this comment.
Yeah, this one is marginal. I'll look at ArcStr in a follow-up 🙂
charliermarsh
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switches all
String::deserializecallsites to<Cow<'_, &str>>for opportunistic borrowing. This should be advantageous for us in cases where we immediately discard theStringanyways, e.g. any sort ofparse(s: &str) -> Tcall.See #17327 and onwards for context.
Test Plan
NFC.