Use Cow<str> for deserialization map keys in PypiFile and PyxFile#17327
Merged
woodruffw merged 1 commit intoastral-sh:mainfrom Jan 5, 2026
Merged
Use Cow<str> for deserialization map keys in PypiFile and PyxFile#17327woodruffw merged 1 commit intoastral-sh:mainfrom
Cow<str> for deserialization map keys in PypiFile and PyxFile#17327woodruffw merged 1 commit intoastral-sh:mainfrom
Conversation
Replace `String` with `Cow<'_, str>` when deserializing map keys. This allows serde to borrow strings directly from the input in the common case (no escaping needed), while still correctly handling cases where de-escaping is required. Addresses feedback from astral-sh#17221.
zaniebot
force-pushed
the
claude/fix-uv-17221-kmH49
branch
from
13f82e7 to
be8b17a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
Cow<'_, str>when deserializing map keys. This allows serde to borrow strings directly from the input in the common case (no escaping needed), while still correctly handling cases where de-escaping is required.Addresses feedback from #17221