Skip to content

Stop setting CLICOLOR_FORCE=1 when calling build backends#15472

Merged
zsol merged 1 commit intomainfrom
zsol/jj-kwnswvnoxxpw
Aug 27, 2025
Merged

Stop setting CLICOLOR_FORCE=1 when calling build backends#15472
zsol merged 1 commit intomainfrom
zsol/jj-kwnswvnoxxpw

Conversation

@zsol
Copy link
Member

@zsol zsol commented Aug 23, 2025

Summary

CLICOLOR_FORCE changes the output of underlying build commands, which messes with wrapper tools trying to parse their output.

Closes #12564, closes #15415.

@zsol zsol had a problem deploying to uv-test-registries August 23, 2025 16:10 — with GitHub Actions Error
@zsol zsol force-pushed the zsol/jj-kwnswvnoxxpw branch from f941ec6 to c5c7dc5 Compare August 23, 2025 16:11
@zsol zsol temporarily deployed to uv-test-registries August 23, 2025 16:13 — with GitHub Actions Inactive
@zanieb zanieb requested a review from konstin August 23, 2025 18:53
@zsol zsol marked this pull request as ready for review August 24, 2025 10:42
@charliermarsh
Copy link
Member

Looks like this was added in #3032.

@charliermarsh
Copy link
Member

It's kind of a bummer to lose this, since it seems like a bug in the respect backends, but I agree that failing is worse.

@konstin
Copy link
Member

konstin commented Aug 25, 2025

Do we have upstream reports in the affected build backends? It would be nice to move towards having color again.

@konstin konstin added the bug Something isn't working label Aug 25, 2025
@konstin konstin changed the title build-frontend: stop setting CLICOLOR_FORCE=1 while building Stop setting CLICOLOR_FORCE=1 when calling build backends Aug 25, 2025
@zsol
Copy link
Member Author

zsol commented Aug 27, 2025

I've raised this in the cmake repo at https://gitlab.kitware.com/cmake/cmake/-/issues/27173 but I highly suspect this is going to be an endless game of whack-a-mole. CMake's CUDA plugin also suffers from a similar issue: https://gitlab.kitware.com/cmake/cmake/-/issues/27137

@zsol zsol merged commit 83e42fd into main Aug 27, 2025
96 checks passed
@zsol zsol deleted the zsol/jj-kwnswvnoxxpw branch August 27, 2025 15:28
@thomasbbrunner
Copy link

Just noting that apparently this has already been fixed in cmake: https://gitlab.kitware.com/cmake/cmake/-/merge_requests/11080

See comment in https://gitlab.kitware.com/cmake/cmake/-/issues/27173

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Sep 2, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.8.13` -> `0.8.14` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>astral-sh/uv (astral-sh/uv)</summary>

### [`v0.8.14`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0814)

[Compare Source](astral-sh/uv@0.8.13...0.8.14)

##### Python

- Add managed CPython distributions for aarch64 musl

##### Enhancements

- Add `--python-platform` to `uv pip check` ([#&#8203;15486](astral-sh/uv#15486))
- Add an environment variable for `UV_ISOLATED` ([#&#8203;15428](astral-sh/uv#15428))
- Add logging to the uv build backend ([#&#8203;15533](astral-sh/uv#15533))
- Allow more trailing null bytes in zip files ([#&#8203;15452](astral-sh/uv#15452))
- Allow pinning managed Python versions to specific build versions ([#&#8203;15314](astral-sh/uv#15314))
- Cache PyTorch wheels by default ([#&#8203;15481](astral-sh/uv#15481))
- Reject already-installed wheels that don't match the target platform ([#&#8203;15484](astral-sh/uv#15484))
- Add `--no-install-local` option to `uv sync`, `uv add` and `uv export`  ([#&#8203;15328](astral-sh/uv#15328))
- Include cycle error message in `uv pip` CLI ([#&#8203;15453](astral-sh/uv#15453))

##### Preview features

- Fix format of `{version}` on `uv format` failure ([#&#8203;15527](astral-sh/uv#15527))
- Lock during installs in `uv format` to prevent races ([#&#8203;15551](astral-sh/uv#15551))
- Respect `--project` in `uv format` ([#&#8203;15438](astral-sh/uv#15438))
- Run `uv format` in the project root ([#&#8203;15440](astral-sh/uv#15440))

##### Configuration

- Add file-to-CLI overrides for build isolation configuration ([#&#8203;15437](astral-sh/uv#15437))
- Add file-to-CLI overrides for reinstall configuration ([#&#8203;15426](astral-sh/uv#15426))

##### Performance

- Cache `WHEEL` and `METADATA` reads in installed distributions ([#&#8203;15489](astral-sh/uv#15489))

##### Bug fixes

- Avoid erroring when creating `venv` in current working directory ([#&#8203;15537](astral-sh/uv#15537))
- Avoid introducing unnecessary system dependency on CUDA ([#&#8203;15449](astral-sh/uv#15449))
- Clear discovered site packages when creating virtual environment ([#&#8203;15522](astral-sh/uv#15522))
- Read index credentials from the environment during `uv publish` checks ([#&#8203;15545](astral-sh/uv#15545))
- Refuse to remove non-virtual environments in `uv venv` ([#&#8203;15538](astral-sh/uv#15538))
- Stop setting `CLICOLOR_FORCE=1` when calling build backends ([#&#8203;15472](astral-sh/uv#15472))
- Support file or directory removal for Windows symlinks ([#&#8203;15543](astral-sh/uv#15543))

##### Documentation

- Fix GitHub guide highlight lines ([#&#8203;15443](astral-sh/uv#15443))
- Move Resolver to new Internals section in the Reference ([#&#8203;15465](astral-sh/uv#15465))
- Split the "Authentication" page into sections ([#&#8203;15575](astral-sh/uv#15575))
- Update uninstall docs to mention `uvw.exe` needs to be removed ([#&#8203;15536](astral-sh/uv#15536))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS44OC4wIiwidXBkYXRlZEluVmVyIjoiNDEuODguMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

uv fails to build package with cmake 4.1.0 but system pip succeeds Setting of CLICOLOR_FORCE breaks build backends

4 participants