Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force color for build error messages #3032

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Conversation

konstin
Copy link
Member

@konstin konstin commented Apr 15, 2024

Since we're using anstream's strip stream, we can force color output from child processes and strip them when we redirect to a file

Before:

image

After:

image

Redirecting to a file correctly strips color codes.

@konstin konstin added enhancement New feature or request error messages Messaging when something goes wrong and removed enhancement New feature or request labels Apr 15, 2024
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@konstin konstin merged commit dd55995 into main Apr 15, 2024
38 checks passed
@konstin konstin deleted the konsti/force-color-for-builds branch April 15, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error messages Messaging when something goes wrong
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants