Merged
Conversation
anuraaga
commented
Aug 21, 2025
| .unwrap() | ||
| .read_to_string(&mut record) | ||
| .unwrap(); | ||
| assert_snapshot!(record, @r###" |
Contributor
Author
There was a problem hiding this comment.
I noticed the tests in wheel.rs don't exercise write_hashed, so I added this integration test
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Aug 22, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.8.12` -> `0.8.13` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.8.13`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0813) [Compare Source](astral-sh/uv@0.8.12...0.8.13) ##### Enhancements - Add `--no-install-*` arguments to `uv add` ([#​15375](astral-sh/uv#15375)) - Initialize Git prior to reading author in `uv init` ([#​15377](astral-sh/uv#15377)) - Add CUDA 129 to available torch backends ([#​15416](astral-sh/uv#15416)) - Update Pyodide to 0.28.2 ([#​15385](astral-sh/uv#15385)) ##### Preview features - Add an experimental `uv format` command ([#​15017](astral-sh/uv#15017)) - Allow version specifiers in `extra-build-dependencies` if match-runtime is explicitly `false` ([#​15420](astral-sh/uv#15420)) ##### Bug fixes - Add `triton` to `torch-backend` manifest ([#​15405](astral-sh/uv#15405)) - Avoid panicking when resolver returns stale distributions ([#​15389](astral-sh/uv#15389)) - Fix `uv_build` wheel hashes ([#​15400](astral-sh/uv#15400)) - Treat `--upgrade-package` on the command-line as overriding `upgrade = false` in configuration ([#​15395](astral-sh/uv#15395)) - Restore DockerHub publishing ([#​15381](astral-sh/uv#15381)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS44Mi4xIiwidXBkYXRlZEluVmVyIjoiNDEuODIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
This was referenced Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently record hashes are the hex encoded sha-256 sum. However, they're supposed to be urlsafe-base64-nopad.
https://packaging.python.org/en/latest/specifications/recording-installed-packages/#the-record-file
Fixes #15398
Test Plan
Build any wheel
Unpack the wheel
Before this change, it will fail with a hash mismatch. I could confirm with a local build that now the wheel can be unpacked with the
wheelcommand. While I don't enable hash checking when syncing, presumably it would also currently fail.