Conversation
|
@konstin can you review please? I want to build on the abstractions added here. |
Inspired by #15017, mirror the blocking of `std::fs` symbols in favor of `fs_err` and block `tokio::fs` symbols in favor of `fs_err::tokio`.
Inspired by #15017, mirror the blocking of `std::fs` symbols in favor of `fs_err` and block `tokio::fs` symbols in favor of `fs_err::tokio`.
Inspired by #15017, mirror the blocking of `std::fs` symbols in favor of `fs_err` and block `tokio::fs` symbols in favor of `fs_err::tokio`.
| /// Initialize a [`BinaryDownloadReporter`] for a single binary download. | ||
| pub(crate) fn single(printer: Printer) -> Self { | ||
| let multi_progress = MultiProgress::with_draw_target(printer.target()); | ||
| let root = multi_progress.add(ProgressBar::with_draw_target(Some(1), printer.target())); |
There was a problem hiding this comment.
This is just a copy of
uv/crates/uv/src/commands/reporters.rs
Lines 638 to 652 in 5de39b5
I guess we shouldn't use a MultiProgress? I don't really mind using it for consistency though.
There was a problem hiding this comment.
Non-blocker here (an aesthetic problem if it shows up all, pre-existing code), but setting the length to 1 instead of None seems off, shouldn't we either set a real value or nothing?
There was a problem hiding this comment.
Yeah I.. don't really know much about what's going on here. We can open an issue to dig into it.
|
I believe I've addressed all the feedback. |
konstin
left a comment
There was a problem hiding this comment.
We need to fix the retries thing, everything else looks good
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.8.12` -> `0.8.13` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.8.13`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0813) [Compare Source](astral-sh/uv@0.8.12...0.8.13) ##### Enhancements - Add `--no-install-*` arguments to `uv add` ([#​15375](astral-sh/uv#15375)) - Initialize Git prior to reading author in `uv init` ([#​15377](astral-sh/uv#15377)) - Add CUDA 129 to available torch backends ([#​15416](astral-sh/uv#15416)) - Update Pyodide to 0.28.2 ([#​15385](astral-sh/uv#15385)) ##### Preview features - Add an experimental `uv format` command ([#​15017](astral-sh/uv#15017)) - Allow version specifiers in `extra-build-dependencies` if match-runtime is explicitly `false` ([#​15420](astral-sh/uv#15420)) ##### Bug fixes - Add `triton` to `torch-backend` manifest ([#​15405](astral-sh/uv#15405)) - Avoid panicking when resolver returns stale distributions ([#​15389](astral-sh/uv#15389)) - Fix `uv_build` wheel hashes ([#​15400](astral-sh/uv#15400)) - Treat `--upgrade-package` on the command-line as overriding `upgrade = false` in configuration ([#​15395](astral-sh/uv#15395)) - Restore DockerHub publishing ([#​15381](astral-sh/uv#15381)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS44Mi4xIiwidXBkYXRlZEluVmVyIjoiNDEuODIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
|
how is it different to uvx ruff format ? seems a bit weird to be honest. |
|
I know this is merged but not a huge fan of this. Is the Do as you do but architecturally this is a bad choice. |
As a frontend to Ruff's formatter.
There are some interesting choices here, some of which may just be temporary:
uv formatis stable for a given uv versionSee astral-sh/ruff#19665 for a prototype of the LSP integration.