Skip to content

Remove missing host short-circuit from canonical URL construction #11087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zanieb wants to merge 1 commit into from
Closed

Remove missing host short-circuit from canonical URL construction #11087

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions crates/uv-cache-key/src/canonical_url.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,6 @@ impl CanonicalUrl {
return Self(url);
}

// If the URL has no host, then it's not a valid URL anyway.
if !url.has_host() {
return Self(url);
}

// Strip credentials.
let _ = url.set_password(None);
let _ = url.set_username("");
Expand Down