Remove missing host short-circuit from canonical URL construction#11087
Closed
Remove missing host short-circuit from canonical URL construction#11087
Conversation
This was added in 93d606a when `Url::set_password` (and username) were unwrapped but now we just ignore those errors
Member
Author
|
Ah it's #11088 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was added in 93d606a when
Url::set_password(and username) were unwrapped but now we just ignore those errors (those functions require the URL to have a host).Removed this to see if it changed any tests and figured I'd commit it, @charliermarsh is poking at it so maybe he's changing behavior that relies on removing this to allow canonicalization of
file://URLs (which don't have a host).