Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test coverage for registry that requires basic HTTP authentication #2447

Closed
zanieb opened this issue Mar 14, 2024 · 3 comments · Fixed by #2463
Closed

Add unit test coverage for registry that requires basic HTTP authentication #2447

zanieb opened this issue Mar 14, 2024 · 3 comments · Fixed by #2463
Assignees
Labels
registry Related to package indexes and registries testing Internal testing of behavior

Comments

@zanieb
Copy link
Member

zanieb commented Mar 14, 2024

We're missing coverage for this and it's fairly critical.

We'll need to host an index somewhere that we can expose credentials to.

e.g. to prevent regressions like #2444

@zanieb zanieb added testing Internal testing of behavior registry Related to package indexes and registries labels Mar 14, 2024
@zanieb zanieb self-assigned this Mar 14, 2024
@zanieb
Copy link
Member Author

zanieb commented Mar 14, 2024

A NGINX proxy with HTTP basic authentication in progress at astral-sh/pypi-proxy#1

@vlad-ivanov-name
Copy link

Not sure if this is useful but a few weeks ago I implemented a "simple" pip server for integration tests in pixi:

https://github.com/vlad-ivanov-name/pixi/blob/f52c9ac1772cb623f257cd222e303480bcf76940/tests/common/pypi_server.rs

pixi has since switched to uv as backend so the associated PR was obsolete and was closed, but perhaps the code could be useful here. It creates a local server with Axum and creates wheels on the fly -- all from rust, without needing external processes, containers, etc. Authentication would be really easy to add there via axum auth middleware.

@zanieb
Copy link
Member Author

zanieb commented Mar 15, 2024

Awesome thanks! It's on my wishlist to have a local server for the test suite. I'll take a look at that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
registry Related to package indexes and registries testing Internal testing of behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants