-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 0.1.19 breaks AWS CodeArtifact authentication #2444
Comments
Did you try with |
\cc @zanieb - my guess is this is related to the authentication store in some way? |
Just ran and same result ($UV_INDEX_URL is set as the
|
Okay, thanks! |
## Summary The authentication middleware extracts in-URL credentials from URLs that pass through it; however, by the time a request reaches the store, the credentials will have already been removed, and relocated to the header. So we were never propagating in-URL credentials. This PR adds an explicit pass wherein we pass in-URL credentials to the store prior to doing any work. Closes #2444. ## Test Plan `cargo run pip install` against an authenticated AWS registry.
Thanks for the report! We should have a fix released shortly |
Hi @charliermarsh, I can confirm that this issue was fixed on v0.1.20 (#2446) but the issue came back after v0.1.22 (probably due to #2449?) |
Oh strange! Will take a look. |
Unfortunately I'm not able to reproduce this when running against an authenticated CodeArtifact index. Are you certain that this is the issue you're running into? And certain that you're on the right uv version, etc.? |
I'm certain because I have specified the uv versions on a requirements.txt file I used for a project. The only versions where it doesn't worked are "uv==0.1.19" and "uv==0.1.22". The index url I am trying to use points to a private JFrog artifactory PyPI repository. |
@ealap can you open a new issue please and provide verbose logs ( This issue is for AWS CodeArtifact. |
Sorry, I thought the root issue was generally for basic HTTP authentication / in-URL credentials. I will create a separate issue. |
uv
version 0.1.19 gives a 401 error when connecting to a CodeArtifact repo, where 0.1.18 works fine.uv version: 0.1.19
platform: macOS 14.4 (23E214)
Example:
uv pip install -r requirements.txt --index-url https://aws:<redacted-key>@<redacted-subdomain>.codeartifact.us-east-1.amazonaws.com/pypi/eng/simple/
Can't give a repro but it does track with the changes to authentication between 0.1.18 and 0.1.19. The module that fails changes each time, so not specific to the module.
The text was updated successfully, but these errors were encountered: