Add script to update ty.json in schemastore#65
Merged
MichaReiser merged 2 commits intomainfrom May 8, 2025
Merged
Conversation
4ef2410 to
dfe534c
Compare
Member
You could crib this from the |
Member
Author
Yeah, updating feels a bit aggressive but I think it's important to warn if someone is on a stale revision. I've to figure out how to check that. |
a2e805c to
47c9408
Compare
MichaReiser
commented
May 7, 2025
Member
Author
There was a problem hiding this comment.
This is mostly just copy paste from the ruff repository. The only real addition is in main where we check the state of the ruff submodule
47c9408 to
24cf146
Compare
24cf146 to
e80caba
Compare
zanieb
reviewed
May 7, 2025
zanieb
reviewed
May 7, 2025
zanieb
reviewed
May 7, 2025
zanieb
added a commit
that referenced
this pull request
May 8, 2025
Mostly making sure that the script is robust to alternative working directories, and some stylistic nits. Following up on #65 (comment) — not to be annoying, but using `git` to find the root _can_ be wrong here ``` ❯ cd ruff ❯ uv run --only-dev ../scripts/update_schemastore.py > /Users/zb/workspace/ty/scripts/update_schemastore.py(146)main() -> breakpoint() (Pdb) print(root) /Users/zb/workspace/ty/ruff ```
epitech314
added a commit
to epitech314/ty
that referenced
this pull request
Nov 12, 2025
Mostly making sure that the script is robust to alternative working directories, and some stylistic nits. Following up on astral-sh/ty#65 (comment) — not to be annoying, but using `git` to find the root _can_ be wrong here ``` ❯ cd ruff ❯ uv run --only-dev ../scripts/update_schemastore.py > /Users/zb/workspace/ty/scripts/update_schemastore.py(146)main() -> breakpoint() (Pdb) print(root) /Users/zb/workspace/ty/ruff ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a script to update ty's schema in the schemastore repository
Closes #13
Test plan
https://github.com/astral-sh/schemastore/pull/new/update-ty-52d16b44bcc060bec0a0381a1ea8052bf4479f14