Skip to content

Clean up some path handling in the schemastore script#273

Merged
zanieb merged 1 commit intomainfrom
zb/schema-store
May 8, 2025
Merged

Clean up some path handling in the schemastore script#273
zanieb merged 1 commit intomainfrom
zb/schema-store

Conversation

@zanieb
Copy link
Member

@zanieb zanieb commented May 8, 2025

Mostly making sure that the script is robust to alternative working directories, and some stylistic nits.

Following up on #65 (comment) — not to be annoying, but using git to find the root can be wrong here

❯ cd ruff
❯ uv run --only-dev ../scripts/update_schemastore.py
> /Users/zb/workspace/ty/scripts/update_schemastore.py(146)main()
-> breakpoint()
(Pdb) print(root)
/Users/zb/workspace/ty/ruff

zanieb added a commit to astral-sh/ruff that referenced this pull request May 8, 2025
@zanieb zanieb added the internal An internal refactor or improvement label May 8, 2025
@zanieb zanieb merged commit d50d72c into main May 8, 2025
9 checks passed
@zanieb zanieb deleted the zb/schema-store branch May 8, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant