Add optimized best_fit_parenthesize IR

[MichaReiser]

Summary

This PR adds a custom IR for content that should only be parenthesized if it makes it fit. The custom IR removes the need to use the costly BestFitting IR element, allowing us to remove the poor heuristic around when to use the BestFit layout (because the IR is now cheap).

The main downside of the custom IR is that it is less tested and further increases the complexity of the Printer (It is re-implementation of BestFitting with the three variants)

Closes #7463
Closes #7067
Closes #7462

Test Plan

cargo test

Base

project	similarity index	total files	changed files
cpython	0.76083	1789	1632
django	0.99982	2760	37
transformers	0.99957	2587	398
twine	1.00000	33	0
typeshed	0.99983	3496	18
warehouse	0.99929	648	16
zulip	0.99962	1437	22

This PR

project	similarity index	total files	changed files
cpython	0.76083	1789	1631
django	0.99983	2760	36
transformers	0.99956	2587	404
twine	1.00000	33	0
typeshed	0.99983	3496	18
warehouse	0.99929	648	16
zulip	0.99969	1437	21

New transformers deviations: There are a few new transformers deviations of the form:

if True:
    if True:
        if True:
			model.config.use_cache = False  # FSTM still requires this hack -> FSTM should probably be refactored similar to BART afterward

# Formatted
if True:
    if True:
        if True:
			model.config.use_cache = (
				False
			)  # FSTM still requires this hack -> FSTM should probably be refactored similar to BART afterward

This is because the BestFit layout is now also applied for constants.

The formatting is now consistent with a 6 character identifier:

if True:
    if True:
        if True:
            model.config.use_cache = aaaaaa  # FSTM still requires this hack -> FSTM should probably be refactored similar to BART afterward

# Formatted
if True:
    if True:
        if True:
            model.config.use_cache = (
                aaaaaa
            )  # FSTM still requires this hack -> FSTM should probably be refactored similar to BART afterward

[MichaReiser]

Current dependencies on/for this PR:

• main
  • PR Add optimized best_fit_parenthesize IR #7475 👈

This comment was auto-generated by Graphite.

[codspeed-hq]

CodSpeed Performance Report

Merging #7475 will improve performances by 9.15%

_{Comparing optional-parentheses-ir (81333ac) with main (28b48ab)}

Summary

⚡ 4 improvements
✅ 21 untouched benchmarks

Benchmarks breakdown

	Benchmark	main	optional-parentheses-ir	Change
⚡	formatter[pydantic/types.py]	20.8 ms	19.3 ms	+7.62%
⚡	formatter[large/dataset.py]	57.3 ms	52.5 ms	+9.15%
⚡	formatter[numpy/ctypeslib.py]	10.7 ms	9.9 ms	+7.9%
⚡	formatter[unicode/pypinyin.py]	3.6 ms	3.4 ms	+7.92%

[MichaReiser]

These didn't use the best_fitting layout before because they were excluded by the use_best_fit. This is more consistent

[MichaReiser]

It's now cheap enough to always use BestFit. We only need to avoid it in cases where we never want parentheses

[MichaReiser]

Thanks @charliermarsh for adding these methods. It makes it straightforward to replace one API with the other :)

[charliermarsh]

This looks great, and the speedups are impressive, though I'll admit I'm not very familiar with the printer internals.