Skip to content

`should_use_best_fit with comments#7023

Closed
davidszotten wants to merge 2 commits intoastral-sh:mainfrom
davidszotten:should-use-best-fit-with-comments
Closed

`should_use_best_fit with comments#7023
davidszotten wants to merge 2 commits intoastral-sh:mainfrom
davidszotten:should-use-best-fit-with-comments

Conversation

@davidszotten
Copy link
Contributor

draft for discussion

also use trailing comment length in the should_use_best_fit text length heuristic

#5630 (comment)

currently unstable

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 31, 2023

CodSpeed Performance Report

Merging #7023 will degrade performances by 2.9%

Comparing davidszotten:should-use-best-fit-with-comments (0b55fbd) with main (f4ba0ea)

Summary

❌ 1 regressions
✅ 19 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main davidszotten:should-use-best-fit-with-comments Change
linter/default-rules[large/dataset.py] 91.5 ms 94.3 ms -2.9%

@cnpryer
Copy link
Contributor

cnpryer commented Aug 31, 2023

Is this related? #6830 (comment)

@MichaReiser
Copy link
Member

This is fixed with #7475

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants