Repository navigation
[ruff] Add ctypes.LittleEndianStructure and others alike to existing exception (RUF012) - #27753
Merged
Merged
Conversation
|
Contributor
Author
|
I made some mistakes. I saw some CI mails about it. 😮 |
royb3
force-pushed
the
ruff012-ctypes-more-exceptions
branch
from
August 14, 2026 14:03
f6cd89c to
5f7869b
Compare
ntBre
changed the title
ruff] Add ctypes.LittleEndianStructure and others alike to existing exception (RUF012)
George-Ogden
pushed a commit
to George-Ogden/ruff
that referenced
this pull request
Aug 16, 2026
…ing exception (`RUF012`) (astral-sh#27753) ## Summary astral-sh#22559 Added an exception to the _fields_ Class Variable not needing an annotation. I have the same issue as what the fix is supposed to fix for certain variants of ctypes.Structure. ## Test Plan I extended the ruff012.py file with extra base types and then I added the extra base types to the helper.rs function that detected the original case. Then I updated the snapshot, as the output is what I now expect.
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#22559 Added an exception to the fields Class Variable not needing an annotation.
I have the same issue as what the fix is supposed to fix for certain variants of ctypes.Structure.
Test Plan
I extended the ruff012.py file with extra base types and then I added the extra base types to the helper.rs function that detected the original case. Then I updated the snapshot, as the output is what I now expect.