Repository navigation
[flake8-bandit] Also check keyword arguments (S602, S603, S607, S609) - #27687
Merged
ntBre merged 4 commits intoAug 12, 2026
Merged
Conversation
ntBre
added
the
bug
ntBre
changed the title
flake8-bandit] Also check keyword arguments (S602, S603, S607, S609)
ntBre
enabled auto-merge (squash)
August 12, 2026 14:12
George-Ogden
pushed a commit
to George-Ogden/ruff
that referenced
this pull request
Aug 16, 2026
…`, `S609`) (astral-sh#27687) ## Summary Fix false negatives for subprocess commands passed as `args=`, including `S602`, `S603`, `S607`, and `S609`. Preserve conservative diagnostics for starred command arguments and avoid treating `os.execv(..., args=...)` argument vectors as executable paths. Closes astral-sh#27631 ## Test Plan - `cargo test -p ruff_linter flake8_bandit::tests::rules` - `uv run --only-group dev --locked prek run --files ...` --------- Co-authored-by: Brent Westbrook <brentrwestbrook@gmail.com>
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix false negatives for subprocess commands passed as
args=, includingS602,S603,S607, andS609. Preserve conservative diagnostics for starred command arguments and avoid treatingos.execv(..., args=...)argument vectors as executable paths.Closes #27631
Test Plan
cargo test -p ruff_linter flake8_bandit::tests::rulesuv run --only-group dev --locked prek run --files ...