Skip to content

[pylint] Fix PLE1307 false positive with bools #27651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntBre merged 2 commits into from
Aug 11, 2026
Merged

[pylint] Fix PLE1307 false positive with bools #27651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03625fe
Baseline test for using bools and string formatters (false positive)
Andrej730 Aug 11, 2026
6f3e7bf
Fix false positive when using booleans with string formatters
Andrej730 Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions crates/ruff_linter/resources/test/fixtures/pylint/bad_string_format_type.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,3 +66,6 @@

# No errors here, will be reported separately by bad-string-format-character.
"%b" % b"xx"

# bool is acceptable as int/float/character.
"%d %c %f" % (True, True, True)
4 changes: 2 additions & 2 deletions crates/ruff_linter/src/rules/pylint/rules/bad_string_format_type.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,11 @@ impl FormatType {
self,
FormatType::Unknown | FormatType::String | FormatType::Repr
),
PythonType::Number(NumberLike::Complex | NumberLike::Bool) => matches!(
PythonType::Number(NumberLike::Complex) => matches!(
self,
FormatType::Unknown | FormatType::String | FormatType::Repr
),
PythonType::Number(NumberLike::Integer) => matches!(
PythonType::Number(NumberLike::Integer | NumberLike::Bool) => matches!(
self,
FormatType::Unknown
| FormatType::String
Expand Down
Loading