Repository navigation
[pylint] Fix PLE1307 false positive with bools - #27651
Merged
Merged
Conversation
|
ntBre
added
the
bug
George-Ogden
pushed a commit
to George-Ogden/ruff
that referenced
this pull request
Aug 16, 2026
## Summary Was working on a refactor for https://docs.astral.sh/ruff/rules/bad-string-format-type/ and found a bug - it incorrectly flags any use of bools unless they're used with `%s`, `%r`. See example below, on the runtime it runs without errors and prints `1 \x01 1.000000`. ```python | 1 | # PLE1307 Format type does not match argument type 2 | # OK. 3 | print("%d %c %f" % (True, True, True)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ``` ## Test Plan Added new test - note it's producing an error in 03625fe and fixed in 6f3e7bf All previous tests also pass.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Was working on a refactor for https://docs.astral.sh/ruff/rules/bad-string-format-type/ and found a bug - it incorrectly flags any use of bools unless they're used with
%s,%r. See example below, on the runtime it runs without errors and prints1 \x01 1.000000.Test Plan
Added new test - note it's producing an error in 03625fe and fixed in 6f3e7bf
All previous tests also pass.