[ty] Infer generic class pattern capture types - #26479
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a class pattern matches a generic subclass through a specialized base-class subject, captures declared on the subclass previously fell back to
Unknownorobject. Narrowing retained the base specialization, but member lookup still used an unspecialized pattern class.This infers the pattern subclass's type arguments by solving the mapping from its generic base to the subject class. We use the result only when every pattern-class type variable has one exact invariant solution; covariant bases and unconstrained parameters keep the existing conservative fallback:
Closes astral-sh/ty#3879.