feat(lint): Upgrade ty

[matthewgrossman]

Signed-off-by: Matthew Grossman mgrossman@nvidia.com

This includes astral-sh/ruff#26479, which helps my nemoclient efforts greatly!

Summary by CodeRabbit

Summary by CodeRabbit

• Chores
  • Updated the pinned development type-checking tool version.
  • Refreshed the CI-only type-check suppression list to align with the updated tool and existing known issues.
  • Updated the CI type-check command to tolerate warnings (without breaking the pipeline).
• Type Safety
  • Improved generic type preservation for logging decorators to keep the wrapped class type.
• Tests
  • Adjusted type-check suppressions in several tests; runtime behavior and assertions are unchanged.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

Updates ty to 0.0.56, changes CI lint handling for warnings, and revises inline type-check ignores plus a few typing annotations across SDK, plugins, tests, and services.

Changes

ty Upgrade and CI Linting

Layer / File(s)	Summary
ty version and CI linting pyproject.toml, tools/lint/lint-python-types.sh	ty is bumped in dev dependencies, the CI suppression list is revised, and the lint command adds --exit-zero-on-warning.

SDK Resilience and Tests

Layer / File(s)	Summary
Evaluator resilience annotations packages/nemo_evaluator_sdk/src/nemo_evaluator_sdk/resilience/api.py, packages/nemo_evaluator_sdk/src/nemo_evaluator_sdk/resilience/scheduler.py, packages/nemo_evaluator_sdk/tests/metrics/test_llm_judge.py, packages/nemo_evaluator_sdk/tests/test_agent_inference.py	ty ignores are added to resilience parameter annotations and matching evaluator test call sites.
Platform plugin typing fixes packages/nemo_platform_plugin/src/nemo_platform_plugin/_spec_flags.py, packages/nemo_platform_plugin/src/nemo_platform_plugin/function.py, packages/nemo_platform_plugin/tests/test_dispatcher.py, packages/nemo_platform_plugin/tests/test_function_context.py, packages/nemo_platform_plugin/tests/test_inference_middleware.py, packages/nemo_platform_plugin/tests/test_job_context.py	Helper functions, decorator metadata, and test call sites expand or add type-ignore comments, with the decorator schema declaration keeping its existing type shape.
Testing client and container import ignores packages/nmp_testing/src/nmp/testing/client.py, plugins/nemo-agents/src/nemo_agents_plugin/container/builder.py, plugins/nemo-agents/src/nemo_agents_plugin/container/metadata.py, plugins/nemo-agents/src/nemo_agents_plugin/container/publisher.py, tools/mcp-dev-tools/nmp_dev_mcp.py	Generator yields and unresolved imports pick up ty suppressions in the test client, container helpers, and MCP tool import.
Typed logging and service class vars plugins/nemo-anonymizer/src/nemo_anonymizer_plugin/sdk/logging.py, plugins/nemo-data-designer/src/nemo_data_designer_plugin/sdk/logging.py, plugins/nemo-data-designer/src/nemo_data_designer_plugin/cli/renderers.py, services/studio/src/nmp/studio/service.py	Two logging decorators switch to TypeVar-preserved class typing, renderer calls add extra ignore codes, and StudioService.dependencies becomes a ClassVar.
Docker deployment test ignores plugins/nemo-deployments/tests/integration/backends/docker/test_docker_backend.py, plugins/nemo-deployments/tests/integration/test_reconcile_docker.py, plugins/nemo-deployments/tests/unit/backends/docker/docker_helpers.py, plugins/nemo-deployments/tests/unit/backends/docker/test_probes.py	Docker deployment configs and probe constructions add unknown-argument suppressions in unit and integration tests.

Possibly related PRs

• NVIDIA-NeMo/nemo-platform#14: Shares the nemo-agents container module area where unresolved-import ignores were added.
• NVIDIA-NeMo/nemo-platform#399: Touches the same Docker deployment test helpers and config shapes that now carry unknown-argument suppressions.

Suggested labels: fix

Suggested reviewers: mckornfield

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: upgrading ty for lint tooling.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch mgrossman/GENERIC2-crud-aircore-827-migrate-first-plugin-to-nemoclient-typed-http-client-files-

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Suite	Lines Covered	Line Rate	Branch Rate
Unit Tests	22513/29630	76.0%	60.9%
Integration Tests	13004/28310	45.9%	19.4%

[coderabbitai]

🧹 Nitpick comments (1)

tools/lint/lint-python-types.sh (1)

38-38: 🧹 Nitpick | 🔵 Trivial | ⚡ Quick win

--exit-zero-on-warning silences all warnings, not just the three cited.

Per ty docs, this flag makes ty "Use exit code 0 if there are no error-level diagnostics" — i.e. it suppresses CI failure for any warning-level rule, not only unsupported-base, unused-type-ignore-comment, redundant-cast mentioned in the commit message. Future warning-level regressions (in rules not in ci_ignored_rules) will silently pass CI too. Consider --ignore for just those three rules (or --warn demotion) instead of blanket --exit-zero-on-warning, to keep other warnings failing the build.

[reliability_and_availability]

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tools/lint/lint-python-types.sh` at line 38, The ty invocation in
lint-python-types.sh is using a blanket warning suppression flag that lets every
warning-level diagnostic pass CI, not just the three intended rules. Update the
lint command around uv run and ty check to scope suppression only to
unsupported-base, unused-type-ignore-comment, and redundant-cast, using ty’s
per-rule ignore or warn handling instead of --exit-zero-on-warning, so other
warning-level regressions still fail the build.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@tools/lint/lint-python-types.sh`:
- Line 38: The ty invocation in lint-python-types.sh is using a blanket warning
suppression flag that lets every warning-level diagnostic pass CI, not just the
three intended rules. Update the lint command around uv run and ty check to
scope suppression only to unsupported-base, unused-type-ignore-comment, and
redundant-cast, using ty’s per-rule ignore or warn handling instead of
--exit-zero-on-warning, so other warning-level regressions still fail the build.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 476ff565-c22e-4f0b-b895-9fd6b9a6fe60

📥 Commits

Reviewing files that changed from the base of the PR and between 09fb22b and 602b7f9.

📒 Files selected for processing (1)

• tools/lint/lint-python-types.sh