Skip to content

Build call keywords directly in ThinVec #26227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MichaReiser wants to merge 3 commits into from
Closed

Build call keywords directly in ThinVec #26227

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5e40f4
Build call keywords directly in ThinVec
micha-oai Jun 22, 2026
c4fb91c
Avoid reserving single-keyword calls
MichaReiser Jun 22, 2026
a9bdfe1
Shrink call keywords to fit
MichaReiser Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions crates/ruff_python_parser/src/parser/expression.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ use std::ops::Deref;

use bitflags::bitflags;
use rustc_hash::{FxBuildHasher, FxHashSet};
use thin_vec::ThinVec;

use ruff_python_ast::name::Name;
use ruff_python_ast::token::TokenKind;
Expand Down Expand Up @@ -806,7 +807,7 @@ impl<'src> Parser<'src> {
self.bump(TokenKind::Lpar);

let mut args = vec![];
let mut keywords = vec![];
let mut keywords = ThinVec::new();
let mut seen_keyword_argument = false; // foo = 1
let mut seen_keyword_unpacking = false; // **foo

Expand Down Expand Up @@ -933,11 +934,13 @@ impl<'src> Parser<'src> {

self.expect(TokenKind::Rpar);

keywords.shrink_to_fit();

let arguments = ast::Arguments {
range: self.node_range(start),
node_index: AtomicNodeIndex::NONE,
args: args.into_boxed_slice(),
keywords: keywords.into(),
keywords,
};

self.validate_arguments(&arguments, has_trailing_comma, context);
Expand Down
Loading