Build call keywords directly in ThinVec - #26227
Closed
MichaReiser wants to merge 3 commits into
Closed
Conversation
MichaReiser
added
performance
Memory usage reportSummary
Significant changesClick to expand detailed breakdownflake8
sphinx
trio
prefect
|
|
Merging this PR will improve performance by 6.39%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Memory | parser[large/dataset.py] |
776.3 KB | 729.7 KB | +6.39% |
Tip
Curious why this is faster? Use the CodSpeed MCP and ask your agent.
Comparing micha/ruff-keyword-thinvec (a9bdfe1) with main (8c03352)
Footnotes
-
4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
|
Member
Author
|
#26798 will solve this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build call keyword lists directly in their final ThinVec, reserving the first slot lazily so calls without keywords remain allocation-free.
In a Django DHAT run, this removed 29.9 MB of total allocations and reduced peak live memory by 245 KB.
Testing: Passed the parser test suite and repository hooks.