[ty] Return getter and setter definitions for properties#24349
Closed
mvanhorn wants to merge 1 commit intoastral-sh:mainfrom
Closed
[ty] Return getter and setter definitions for properties#24349mvanhorn wants to merge 1 commit intoastral-sh:mainfrom
mvanhorn wants to merge 1 commit intoastral-sh:mainfrom
Conversation
Previously, `definitions_for_attribute_in_class_hierarchy` used `break 'scopes` after finding the first definition within a class scope. For properties with both a getter and setter, this returned only the getter definition, causing go-to-definition to show only the getter and preventing correct readonly classification when the setter exists in a different binding. Now the function collects all declarations/bindings from the same scope before breaking, so property getter+setter pairs are both returned. This matches Pylance's behavior as suggested in astral-sh#24065.
mvanhorn
requested review from
AlexWaygood,
carljm,
dcreager,
ibraheemdev and
sharkdp
as code owners
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 86.76%. The percentage of expected errors that received a diagnostic held steady at 81.53%. The number of fully passing files held steady at 70/132. |
Memory usage reportMemory usage unchanged ✅ |
|
Member
|
Thanks, and sorry for not mentioning this in your PR but I went ahead and implemented this myself #24332 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #24065 as discussed with @MichaReiser.
definitions_for_attribute_in_class_hierarchynow returns both getter and setter definitions for properties instead of stopping at the first match.Problem
The function used
break 'scopesafter finding the first definition within a class scope's declarations or bindings. For a property with both@propertygetter and@prop.setter, only the getter was returned. This meant:Fix
Instead of breaking immediately on the first definition found, collect all definitions from the same scope (declarations or bindings) before breaking to the next ancestor. The
break 'scopesnow fires after the scope is fully scanned, preserving the MRO traversal behavior while returning complete definition sets.Test plan
property_readonly_modifiertest passes (verifies getter-only = readonly, getter+setter = not readonly)uvx prek run -acleanThis contribution was developed with AI assistance (Claude Code).