[ty] Return all attribute definitions for goto definition

[MichaReiser]

Summary

Instead of only returning the first definition, return all definitions in the same scope.

This ensures that ty returns all definitions of x in the following example instead of just the first:

class Test:
	x: int
	x: int

test = Test()
test.x

This matches the behavior of standalone variables:

x: int = 1
x: int = 2

x

also shows both definitions of x

Test Plan

Added tests

[MichaReiser]

This already worked before because rename tests if the definitions of the renamed symbol and the current symbol's definitions intersect. But I felt it's still worth adding a test for it.

[astral-sh-bot]

Typing conformance results

No changes detected ✅

Current numbers

The percentage of diagnostics emitted that were expected errors held steady at 86.61%. The percentage of expected errors that received a diagnostic held steady at 81.56%. The number of fully passing files held steady at 70/132.

[astral-sh-bot]

Memory usage report

Memory usage unchanged ✅

[astral-sh-bot]

ecosystem-analyzer results

Lint rule	Added	Removed	Changed
invalid-await	0	40	0
invalid-return-type	0	1	0
Total	0	41	0

Changes in flaky projects detected. Raw diff output excludes flaky projects; see the HTML report for details.

Full report with detailed diff (timing results)

[sharkdp]

Hm, interesting. It seems a bit strange to me, but as you pointed out, this is now consistent with what we do for non-class scopes. And it seems like the right choice for renaming, and of course for properties.