Skip to content

FURB167: change example to re.search with ^ anchor #22984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntBre merged 2 commits into from
Jan 30, 2026
+17 −17
Merged

FURB167: change example to re.search with ^ anchor #22984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e05660
FUB167: change example to re.search if using ^ anchor
hugovk Jan 30, 2026
51b896f
fixup! FUB167: change example to re.search if using ^ anchor
hugovk Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions crates/ruff_linter/resources/test/fixtures/refurb/FURB167.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,21 @@ def func():
import re

# OK
if re.match("^hello", "hello world", re.IGNORECASE):
if re.search("^hello", "hello world", re.IGNORECASE):
pass


def func():
import re

# FURB167
if re.match("^hello", "hello world", re.I):
if re.search("^hello", "hello world", re.I):
pass


def func():
from re import match, I
from re import search, I

# FURB167
if match("^hello", "hello world", I):
if search("^hello", "hello world", I):
pass
4 changes: 2 additions & 2 deletions crates/ruff_linter/src/rules/refurb/rules/regex_flag_alias.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,15 @@ use crate::{AlwaysFixableViolation, Edit, Fix};
/// ```python
/// import re
///
/// if re.match("^hello", "hello world", re.I):
/// if re.search("^hello", "hello world", re.I):
/// ...
/// ```
///
/// Use instead:
/// ```python
/// import re
///
/// if re.match("^hello", "hello world", re.IGNORECASE):
/// if re.search("^hello", "hello world", re.IGNORECASE):
/// ...
/// ```
#[derive(ViolationMetadata)]
Expand Down
22 changes: 11 additions & 11 deletions ...ter/src/rules/refurb/snapshots/ruff_linter__rules__refurb__tests__FURB167_FURB167.py.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,29 +2,29 @@
source: crates/ruff_linter/src/rules/refurb/mod.rs
---
FURB167 [*] Use of regular expression alias `re.I`
--> FURB167.py:13:42
--> FURB167.py:13:43
|
12 | # FURB167
13 | if re.match("^hello", "hello world", re.I):
| ^^^^
13 | if re.search("^hello", "hello world", re.I):
| ^^^^
14 | pass
|
help: Replace with `re.IGNORECASE`
10 | import re
11 |
12 | # FURB167
- if re.match("^hello", "hello world", re.I):
13 + if re.match("^hello", "hello world", re.IGNORECASE):
- if re.search("^hello", "hello world", re.I):
13 + if re.search("^hello", "hello world", re.IGNORECASE):
14 | pass
15 |
16 |

FURB167 [*] Use of regular expression alias `re.I`
--> FURB167.py:21:39
--> FURB167.py:21:40
|
20 | # FURB167
21 | if match("^hello", "hello world", I):
| ^
21 | if search("^hello", "hello world", I):
| ^
22 | pass
|
help: Replace with `re.IGNORECASE`
Expand All @@ -33,9 +33,9 @@ help: Replace with `re.IGNORECASE`
3 | import re
4 |
--------------------------------------------------------------------------------
19 | from re import match, I
19 | from re import search, I
20 |
21 | # FURB167
- if match("^hello", "hello world", I):
22 + if match("^hello", "hello world", re.IGNORECASE):
- if search("^hello", "hello world", I):
22 + if search("^hello", "hello world", re.IGNORECASE):
23 | pass
Loading