FURB167: change example to re.search with ^ anchor#22984
Merged
ntBre merged 2 commits intoastral-sh:mainfrom Jan 30, 2026
Merged
FURB167: change example to re.search with ^ anchor#22984ntBre merged 2 commits intoastral-sh:mainfrom
re.search with ^ anchor#22984ntBre merged 2 commits intoastral-sh:mainfrom
Conversation
re.search with ^ anchorre.search with ^ anchor
|
Contributor
|
By the way, if performance is critical, I believe |
This was referenced Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The example for FURB167 has
re.matchwith an^anchor to match the start of the string:But
re.matchalready implicitly matches the start of the string:https://docs.python.org/3/library/re.html#search-vs-match
Let's change the example to
re.searchso the anchor isn't redundant. (The anchor's actually irrelevant to the example for this rule about long or short flag names.)(Aside: There's a discussion about adding
re.prefixmatchand [soft] deprecatingre.matchbecause of the confusion around it: https://discuss.python.org/t/add-re-prefixmatch-deprecate-re-match/105927, python/cpython#86519, python/cpython#31137.)Test Plan
main