[ty] Make infer_subscript_expression_types a method on Type#22731
Merged
charliermarsh merged 1 commit intomainfrom Jan 23, 2026
Merged
[ty] Make infer_subscript_expression_types a method on Type#22731charliermarsh merged 1 commit intomainfrom
infer_subscript_expression_types a method on Type#22731charliermarsh merged 1 commit intomainfrom
Conversation
charliermarsh
force-pushed
the
charlie/int-method
branch
from
a15f0c4 to
098cc9d
Compare
charliermarsh
added
ty
|
charliermarsh
requested review from
AlexWaygood,
carljm,
dcreager and
sharkdp
as code owners
Member
Author
|
Okay, looks like a no-op as expected (those look like the usual suspects in mypy-primer). |
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
invalid-return-type |
1 | 4 | 4 |
invalid-assignment |
0 | 4 | 1 |
invalid-argument-type |
0 | 2 | 1 |
| Total | 1 | 10 | 6 |
Typing conformance resultsNo changes detected ✅ |
MichaReiser
reviewed
Jan 19, 2026
MichaReiser
reviewed
Jan 19, 2026
AlexWaygood
reviewed
Jan 19, 2026
charliermarsh
force-pushed
the
charlie/int-method
branch
2 times, most recently
from
4009a13 to
1fc1615
Compare
Member
|
(will review tomorrow morning -- thank you!) |
charliermarsh
force-pushed
the
charlie/int-method
branch
3 times, most recently
from
4e92b43 to
39886cf
Compare
charliermarsh
force-pushed
the
charlie/int-method
branch
2 times, most recently
from
933dfc8 to
4d6aa20
Compare
AlexWaygood
approved these changes
Jan 23, 2026
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Thank you! Another one we've known we've needed to do for a long time now
Member
There was a problem hiding this comment.
nit: add a short module docstring?
| #[derive(Debug)] | ||
| pub(crate) struct SubscriptError<'db> { | ||
| result_ty: Type<'db>, | ||
| errors: Vec<SubscriptErrorKind<'db>>, |
Member
There was a problem hiding this comment.
IIUC, I think in the common case there's likely to be only 1 error, so maybe this should be a SmallVec<[SubscriptErrorKind<'db>; 1]>`?
Member
There was a problem hiding this comment.
Using a Vec here has the advantage that the very common case (no error) is small. Using a SmallVec probably requires boxing the SubscriptError in the Result, so that it remains small.
Member
There was a problem hiding this comment.
(no strong opinion, happy to defer to you)
MichaReiser
reviewed
Jan 23, 2026
| IndexOutOfBounds { | ||
| kind: &'static str, | ||
| tuple_ty: Type<'db>, | ||
| length: String, |
Member
There was a problem hiding this comment.
Nit
Suggested change
| length: String, | |
| length: Box<str>, |
AlexWaygood
reviewed
Jan 23, 2026
| pub(crate) enum SubscriptErrorKind<'db> { | ||
| /// An index is out of bounds for a literal tuple/string/bytes subscript. | ||
| IndexOutOfBounds { | ||
| kind: &'static str, |
Member
There was a problem hiding this comment.
I guess it would be nice to use a small enum for this field (and similar ones on other variants) rather than &'static str -- it would be more readable and more strongly typed.
charliermarsh
force-pushed
the
charlie/int-method
branch
from
4d6aa20 to
2ee10b1
Compare
carljm
added a commit
that referenced
this pull request
Jan 30, 2026
* main: (62 commits) [`refurb`] Do not add `abc.ABC` if already present (`FURB180`) (#22234) [ty] Add a new `assert-type-unspellable-subtype` diagnostic (#22815) [ty] Avoid duplicate syntax errors for `await` outside functions (#22826) [ty] Fix unary operator false-positive for constrained TypeVars (#22783) [ty] Fix binary operator false-positive for constrained TypeVars (#22782) [ty] Fix false-positive `unsupported-operator` for "symmetric" TypeVars (#22756) [`pydocstyle`] Clarify which quote styles are allowed (`D300`) (#22825) [ty] Use distributed versions of AND and OR on constraint sets (#22614) [ty] Add support for dict literals and dict() calls as default values for parameters with TypedDict types (#22161) Document `-` stdin convention in CLI help text (#22817) [ty] Make `infer_subscript_expression_types` a method on `Type` (#22731) [ty] Simplify `OverloadLiteral::spans` and `OverloadLiteral::parameter_span` (#22823) [ty] Require both `*args` and `**kwargs` when calling a `ParamSpec` callable (#22820) [ty] Handle tagged errors in conformance (#22746) Add `--color` cli option to force colored output (#22806) Identify notebooks by LSP didOpen instead of `.ipynb` file extension (#22810) [ty] Fix docstring rendering for literal blocks after doctests (#22676) [ty] Update salsa to fix out-of-order query validation (#22498) [ty] Inline cycle initial and recovery functions (#22814) [ty] Pass the generic context through the decorator (#22544) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A refactor in anticipation of #22654.