Improve performance of loading range suppressions#22428
Improve performance of loading range suppressions#22428
Conversation
|
CodSpeed Performance ReportMerging this PR will degrade performance by 17.64%Comparing Summary
Performance Changes
|
|
codspeed not happy 🤪 |
|
|
|
||
| /// The ranges of all indent/dedent blocks in the source document. | ||
| block_ranges: BlockRanges, |
There was a problem hiding this comment.
I prefer avoiding adding new state to Indexer because it's state that we can't release until the file has finished checking. That's why we generally prefer re-computing information unless doing so is expensive or has to be repeated in many places (recomputing can often also be cheaper).
Are there cases where the implementation in #21441 (review) falls short, making computing this information ahead of time necessary?
WIP, not fully baked, checkpointing progress:
issue #22087