[ty] Collect mdtest failures as part of the assertion message rather than printing them to the terminal immediately#22081
Merged
AlexWaygood merged 1 commit intomainfrom Dec 19, 2025
Merged
Conversation
…than printing them to the terminal immediately
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
sharkdp
approved these changes
Dec 19, 2025
Contributor
sharkdp
left a comment
There was a problem hiding this comment.
Thank you!
Does it also look okay when running via cargo?
|
Member
Author
Yup! Screen.Recording.2025-12-19.at.13.47.39.movIt still doesn't look great when invoked via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This greatly improves the experience of running
mdtest.pyin a VSCode terminal now that we switched to using datatest rather than dirtest.On
main, with mdtest failures:Screen.Recording.2025-12-19.at.13.40.43.mov
With this PR, with the same mdtest failures:
Screen.Recording.2025-12-19.at.13.41.53.mov
I can now once again easily jump directly to the mdtest assertions that are failing from my in-editor terminal, because all the mdtest failing lines are collected at the bottom of the terminal after
mdtest.pyhas finished runnning