[ty] Report when a dataclass contains more than one KW_ONLY field#18731
Merged
carljm merged 4 commits intoastral-sh:mainfrom Jun 20, 2025
Merged
[ty] Report when a dataclass contains more than one KW_ONLY field#18731carljm merged 4 commits intoastral-sh:mainfrom
KW_ONLY field#18731carljm merged 4 commits intoastral-sh:mainfrom
Conversation
Contributor
|
InSyncWithFoo
force-pushed
the
ty-dataclasses-duplicate-kw-only
branch
from
bab19ad to
c93c828
Compare
InSyncWithFoo
requested review from
AlexWaygood,
MichaReiser,
carljm,
dcreager and
sharkdp
as code owners
Contributor
Author
|
Currently the diagnostic doesn't look quite as nice as I want it to be. I think it should show all offending fields in subdiagnostics, but
@dataclass
class C:
a: KW_ONLY
a: KW_ONLY # Same name |
Member
That doesn't cause a |
carljm
approved these changes
Jun 18, 2025
...dtest/snapshots/dataclasses.md_-_Dataclasses_-_`dataclasses.KW_ONLY…_(dd1b8f2f71487f16).snap
Outdated
Show resolved
Hide resolved
...dtest/snapshots/dataclasses.md_-_Dataclasses_-_`dataclasses.KW_ONLY…_(dd1b8f2f71487f16).snap
Outdated
Show resolved
Hide resolved
Contributor
abhijeetbodas2001
left a comment
abhijeetbodas2001
left a comment
There was a problem hiding this comment.
Thanks! For me, this diff is also helpful as a tutorial on how to add a new diagnostic :)
Contributor
Another idea for a lint rule here could be to recommend using |
dcreager
added a commit
that referenced
this pull request
Jun 20, 2025
* main: (21 commits) [`flake8-logging`] Avoid false positive for `exc_info=True` outside `logger.exception` (`LOG014`) (#18737) [`flake8-pie`] Small docs fix to `PIE794` (#18829) [`pylint`] Ignore __init__.py files in (PLC0414) (#18400) Avoid generating diagnostics with per-file ignores (#18801) [`flake8-simplify`] Fix false negatives for shadowed bindings (`SIM910`, `SIM911`) (#18794) [ty] Fix panics when pulling types for `ClassVar` or `Final` parameterized with >1 argument (#18824) [`pylint`] add fix safety section (`PLR1714`) (#18415) [Perflint] Small docs improvement to `PERF401` (#18786) [`pylint`] Avoid flattening nested `min`/`max` when outer call has single argument (`PLW3301`) (#16885) [`ruff`] Added `cls.__dict__.get('__annotations__')` check (`RUF063`) (#18233) [ty] Use `HashTable` in `PlaceTable` (#18819) docs: Correct collections-named-tuple example to use PascalCase assignment (#16884) [ty] ecosystem-analyzer workflow (#18719) [ty] Add support for `@staticmethod`s (#18809) unnecessary_dict_kwargs doc - a note on type checking benefits (#18666) [`flake8-pytest-style`] Mark autofix for `PT001` and `PT023` as unsafe if there's comments in the decorator (#18792) [ty] Surface matched overload diagnostic directly (#18452) [ty] Report when a dataclass contains more than one `KW_ONLY` field (#18731) [`flake8-pie`] Add fix safety section to `PIE794` (#18802) [`pycodestyle`] Add fix safety section to `W291` and `W293` (#18800) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #111.
After this change, dataclasses with two or more
KW_ONLYfield will be reported as invalid. The duplicate fields will simply be ignored when computing__init__'s signature.Test Plan
Markdown tests.