docs: Correct collections-named-tuple example to use PascalCase assignment#16884
Merged
AlexWaygood merged 1 commit intoastral-sh:mainfrom Jun 20, 2025
Merged
Conversation
…nment Signed-off-by: Gene Parmesan Thomas <201852096+gopoto@users.noreply.github.com>
Contributor
|
Member
|
Closing because we never got to reviewing this PR. |
Member
|
This change seems correct to me |
AlexWaygood
approved these changes
Jun 20, 2025
Member
AlexWaygood
left a comment
There was a problem hiding this comment.
thanks! Sorry it took us a while to review
dcreager
added a commit
that referenced
this pull request
Jun 20, 2025
* main: (21 commits) [`flake8-logging`] Avoid false positive for `exc_info=True` outside `logger.exception` (`LOG014`) (#18737) [`flake8-pie`] Small docs fix to `PIE794` (#18829) [`pylint`] Ignore __init__.py files in (PLC0414) (#18400) Avoid generating diagnostics with per-file ignores (#18801) [`flake8-simplify`] Fix false negatives for shadowed bindings (`SIM910`, `SIM911`) (#18794) [ty] Fix panics when pulling types for `ClassVar` or `Final` parameterized with >1 argument (#18824) [`pylint`] add fix safety section (`PLR1714`) (#18415) [Perflint] Small docs improvement to `PERF401` (#18786) [`pylint`] Avoid flattening nested `min`/`max` when outer call has single argument (`PLW3301`) (#16885) [`ruff`] Added `cls.__dict__.get('__annotations__')` check (`RUF063`) (#18233) [ty] Use `HashTable` in `PlaceTable` (#18819) docs: Correct collections-named-tuple example to use PascalCase assignment (#16884) [ty] ecosystem-analyzer workflow (#18719) [ty] Add support for `@staticmethod`s (#18809) unnecessary_dict_kwargs doc - a note on type checking benefits (#18666) [`flake8-pytest-style`] Mark autofix for `PT001` and `PT023` as unsafe if there's comments in the decorator (#18792) [ty] Surface matched overload diagnostic directly (#18452) [ty] Report when a dataclass contains more than one `KW_ONLY` field (#18731) [`flake8-pie`] Add fix safety section to `PIE794` (#18802) [`pycodestyle`] Add fix safety section to `W291` and `W293` (#18800) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The documentation for
collections-named-tuple(PYI024) was using a lowercase variable in its example:while the recommended replacement used
class Person– implying a name change that's not equivalent. This patch updates the docstring to use a more canonical example:so that the “Use instead:” block aligns with the original name and doesn't suggest a breaking rename. No functional code changes were required.
Test Plan
Only documentation comments were updated; the existing
flake8_pyitests still pass (cargo test -p ruff_linter). Running the full workspace tests yields a failure in an unrelated snapshot when run as root, but in a typical developer environment the existing tests and snapshots remain unaffected. All style and lint checks pass (cargo clippy,cargo fmt, etc.).This PR was generated by an AI system in collaboration with maintainers: @carljm, @ntBre
Fixes #16492