[ty] Add a note to the diagnostic if a new builtin is used on an old Python version#18068
Merged
AlexWaygood merged 1 commit intomainfrom May 13, 2025
Merged
[ty] Add a note to the diagnostic if a new builtin is used on an old Python version#18068AlexWaygood merged 1 commit intomainfrom
AlexWaygood merged 1 commit intomainfrom
Conversation
AlexWaygood
added
ty
Contributor
|
AlexWaygood
force-pushed
the
alex/new-builtins-note
branch
from
dcb1a5c to
a06f9ed
Compare
AlexWaygood
force-pushed
the
alex/new-builtins-note
branch
from
a06f9ed to
2ab9783
Compare
AlexWaygood
commented
May 13, 2025
Member
Author
There was a problem hiding this comment.
all the line numbers here changed because I added an import to the top of diagnostic.rs...
MichaReiser
approved these changes
May 13, 2025
Comment on lines
+1660
to
+1665
| // TODO: can we tell the user *why* we're inferring this target version? | ||
| // CLI flag? pyproject.toml? Python environment? | ||
| diagnostic.info(format_args!( | ||
| "The inferred target version of your project is Python {}", | ||
| Program::get(context.db()).python_version(context.db()) | ||
| )); |
Member
There was a problem hiding this comment.
This shouldn't be too hard. We have the information if it comes from the CLI or configuration but we throw it away when converting it to a ProgramSettings.
carljm
reviewed
May 13, 2025
| // TODO: can we tell the user *why* we're inferring this target version? | ||
| // CLI flag? pyproject.toml? Python environment? | ||
| diagnostic.info(format_args!( | ||
| "The inferred target version of your project is Python {}", |
Contributor
There was a problem hiding this comment.
It seems a bit odd to call it the "inferred" Python version if it came from eg a CLI flag. But I guess this is part of the TODO above?
dcreager
added a commit
that referenced
this pull request
May 13, 2025
…eep-dish * origin/main: [ty] __file__ is always a string inside a Python module (#18071) [ty] Recognize submodules in self-referential imports (#18005) [ty] Add a note to the diagnostic if a new builtin is used on an old Python version (#18068) [ty] Add tests for `else` branches of `hasattr()` narrowing (#18067) [ty] Improve diagnostics for `assert_type` and `assert_never` (#18050) [ty] contribution guide (#18061) [ty] Implement `DataClassInstance` protocol for dataclasses. (#18018) [ruff_python_ast] Fix redundant visitation of test expressions in elif clause statements (#18064)
Glyphack
pushed a commit
to Glyphack/ruff
that referenced
this pull request
May 21, 2025
…Python version (astral-sh#18068) ## Summary If the user tries to use a new builtin on an old Python version, tell them what Python version the builtin was added on, what our inferred Python version is for their project, and what configuration settings they can tweak to fix the error. ## Test Plan Snapshots and screenshots: 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If the user tries to use a new builtin on an old Python version, tell them what Python version the builtin was added on, what our inferred Python version is for their project, and what configuration settings they can tweak to fix the error.
Test Plan
Snapshots and screenshots: