[ruff_python_ast] Fix redundant visitation of test expressions in elif clause statements#18064
Merged
MichaReiser merged 1 commit intoastral-sh:mainfrom May 13, 2025
Merged
[ruff_python_ast] Fix redundant visitation of test expressions in elif clause statements#18064MichaReiser merged 1 commit intoastral-sh:mainfrom
MichaReiser merged 1 commit intoastral-sh:mainfrom
Conversation
MichaReiser
approved these changes
May 13, 2025
Contributor
|
dcreager
added a commit
that referenced
this pull request
May 13, 2025
…eep-dish * origin/main: [ty] __file__ is always a string inside a Python module (#18071) [ty] Recognize submodules in self-referential imports (#18005) [ty] Add a note to the diagnostic if a new builtin is used on an old Python version (#18068) [ty] Add tests for `else` branches of `hasattr()` narrowing (#18067) [ty] Improve diagnostics for `assert_type` and `assert_never` (#18050) [ty] contribution guide (#18061) [ty] Implement `DataClassInstance` protocol for dataclasses. (#18018) [ruff_python_ast] Fix redundant visitation of test expressions in elif clause statements (#18064)
Glyphack
pushed a commit
to Glyphack/ruff
that referenced
this pull request
May 21, 2025
…f clause statements (astral-sh#18064)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix redundant AST visitation of elif clause test expressions
Summary
This PR addresses a bug in the AST traversal logic where the test expressions of elif clauses were being visited multiple times.
Removed the initial redundant visitation call to elif test expressions that originally occurred at
ruff/crates/ruff_python_ast/src/visitor/transformer.rs
Line 237 in 0fb94c0
which duplicated the standard processing already implemented at
ruff/crates/ruff_python_ast/src/visitor/transformer.rs
Line 110 in 0fb94c0
Test Plan