[refurb] Add coverage of set and frozenset calls (FURB171)#18035
Merged
ntBre merged 1 commit intoastral-sh:mainfrom May 29, 2025
Merged
Conversation
Contributor
|
naslundx
force-pushed
the
single-item-membership-test-missing-set-constructor
branch
from
e1e31b0 to
0414342
Compare
ntBre
added
rule
ntBre
changed the title
refurb] Add coverage of set and frozenset calls (FURB171)
ntBre
reviewed
May 14, 2025
Contributor
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
Thanks! The implementation looks reasonable to me. Would you mind moving the new test cases to the end of the test file? That will make it a lot easier to review that part.
Alternatively you could move FURB171.py to FURB171_0.py and add your new tests in FURB171_1.py.
cc @dylwil3 and @AlexWaygood since y'all reviewed the previous iteration of this PR (#15793).
crates/ruff_linter/src/rules/refurb/rules/single_item_membership_test.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/refurb/rules/single_item_membership_test.rs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Fixed the suggested tweaks, will reorg the test cases as well |
naslundx
force-pushed
the
single-item-membership-test-missing-set-constructor
branch
from
e6c2d56 to
2a908cd
Compare
…ItemMembershipTest
naslundx
force-pushed
the
single-item-membership-test-missing-set-constructor
branch
from
2a908cd to
0863a09
Compare
Contributor
Author
|
There we go. Back to you @ntBre ! |
dcreager
added a commit
that referenced
this pull request
May 30, 2025
* main: [ty] support callability of bound/constrained typevars (#18389) [ty] Minor tweaks to "list all members" docs and tests (#18388) [ty] Fix broken property tests for disjointness (#18384) [ty] List available members for a given type (#18251) [`airflow`] Add unsafe fix for module moved cases (`AIR312`) (#18363) Add a `SourceFile` to `OldDiagnostic` (#18356) Update salsa past generational id change (#18362) [`airflow`] Add unsafe fix for module moved cases (`AIR311`) (#18366) [`airflow`] Add unsafe fix for module moved cases (`AIR301`) (#18367) [ty] Improve tests for `site-packages` discovery (#18374) [ty] _typeshed.Self is not a special form (#18377) [ty] Callable types are disjoint from non-callable `@final` nominal instance types (#18368) [ty] Add diagnosis for function with no return statement but with return type annotation (#18359) [`airflow`] Add unsafe fix module moved cases (`AIR302`) (#18093) Rename `ruff_linter::Diagnostic` to `OldDiagnostic` (#18355) [`refurb`] Add coverage of `set` and `frozenset` calls (`FURB171`) (#18035)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ItemMembershipTest
Summary
Adds coverage of using set(...) in addition to `{...} in SingleItemMembershipTest.
Fixes #15792
(and replaces the old PR #15793)
Test Plan
Updated unit test and snapshot.
Steps to reproduce are in the issue linked above.