dependencies: Update salsa to 0.20.0#17566
Closed
CreatedBySeb wants to merge 1 commit intoastral-sh:mainfrom
Closed
dependencies: Update salsa to 0.20.0#17566CreatedBySeb wants to merge 1 commit intoastral-sh:mainfrom
CreatedBySeb wants to merge 1 commit intoastral-sh:mainfrom
Conversation
Contributor
|
Member
|
Thanks for the PR. We're getting close to switching to the crates.io Salsa dependency but there have still been multiple recent occasions where we had to fix a bug in Salsa and the git dependency allowed us to move faster because of it. That's why I want to keep the git dependency for a little longer until things on the salsa side settle down. |
Contributor
|
have things settled down yet? |
Member
|
No |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates
salsato0.20.0as a crate dependency, rather than a git dependency. The previous version was salsa-rs/salsa@87bf6b6, which is included in the0.20.0release (salsa-rs/salsa#753).Removing one of the two git dependencies in Ruff removes a blocker to #43, and given the crates release for salsa is ahead of the depended upon git commit, this seems like a good time to make the swap.
Test Plan
Since this is a dependency change rather than a functional change, I followed the testing from the Contributing docs on both an M1 MacBook Air and an AMD Linux machine.
I used nextest rather than regular test per advice earlier in the guide, but did also try
RUFF_UPDATE_SCHEMA=1 cargo teston the Linux machine in case there was any difference.I was not sure what the correct way to use the fuzzers to test this change might be, since the information on how to use them wasn't very clear to me.