Skip to content

[airflow] Add missing AIR302 attribute check #17115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntBre merged 3 commits into from
Apr 9, 2025
Merged

[airflow] Add missing AIR302 attribute check #17115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a92696b
fix(AIR303): improve test cases and make sure attribute access is als…
Lee-W Apr 1, 2025
f3622fd
test(AIR303): reorganize test cases
Lee-W Apr 1, 2025
d1a7740
test(AIR302): improve fab test cases
Lee-W Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions crates/ruff_linter/resources/test/fixtures/airflow/AIR302.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,7 @@
from airflow.operators.sqlite_operator import SqliteOperator
from airflow.operators.trigger_dagrun import TriggerDagRunOperator
from airflow.operators.weekday import BranchDayOfWeekOperator
from airflow.sensors import filesystem
from airflow.sensors.date_time import DateTimeSensor, DateTimeSensorAsync
from airflow.sensors.date_time_sensor import DateTimeSensor
from airflow.sensors.external_task import (
Expand Down Expand Up @@ -318,13 +319,25 @@
JdbcOperator()

# apache-airflow-providers-fab
basic_auth, kerberos_auth
basic_auth.CLIENT_AUTH
basic_auth.init_app
basic_auth.auth_current_user
basic_auth.requires_authentication

kerberos_auth.log
kerberos_auth.CLIENT_AUTH
kerberos_auth.find_user
kerberos_auth.init_app
kerberos_auth.requires_authentication
auth_current_user
backend_kerberos_auth
fab_override
FabAuthManager()
FabAirflowSecurityManagerOverride()

# check whether attribute access
basic_auth.auth_current_user

# apache-airflow-providers-cncf-kubernetes
ALL_NAMESPACES
POD_EXECUTOR_DONE_KEY
Expand Down Expand Up @@ -422,6 +435,11 @@
EmailOperator()

# apache-airflow-providers-standard
filesystem.FileSensor()
FileSensor()
TriggerDagRunOperator()
ExternalTaskMarker()
ExternalTaskSensor()
BranchDateTimeOperator()
BranchDayOfWeekOperator()
BranchPythonOperator()
Expand Down Expand Up @@ -452,12 +470,12 @@
DateTimeTrigger()
TimeDeltaTrigger()
SubprocessResult()
working_directory()
SubprocessHook()
TimeDeltaSensor()
TimeDeltaSensorAsync()
WaitSensor()
TimeSensor()
TimeSensorAsync()
BranchDateTimeOperator()
working_directory()
target_times_as_dates()
3 changes: 3 additions & 0 deletions crates/ruff_linter/src/checkers/ast/analyze/expression.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,6 +451,9 @@ pub(crate) fn expression(expr: &Expr, checker: &Checker) {
if checker.enabled(Rule::Airflow3Removal) {
airflow::rules::airflow_3_removal_expr(checker, expr);
}
if checker.enabled(Rule::Airflow3MovedToProvider) {
airflow::rules::moved_to_provider_in_3(checker, expr);
}
if checker.enabled(Rule::Airflow3SuggestedToMoveToProvider) {
airflow::rules::suggested_to_move_to_provider_in_3(checker, expr);
}
Expand Down
Loading
Loading