[airflow] Add missing AIR302 attribute check
#17115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Lee-W
force-pushed
the
add-more-AIR303-condition
branch
from
c2f11da to
7aad00e
Compare
This was referenced Apr 1, 2025
Lee-W
force-pushed
the
add-more-AIR303-condition
branch
from
7aad00e to
189cf32
Compare
dhruvmanila
added
rule
dhruvmanila
requested changes
Apr 2, 2025
...linter/src/rules/airflow/snapshots/ruff_linter__rules__airflow__tests__AIR303_AIR303.py.snap
Outdated
Show resolved
Hide resolved
Lee-W
force-pushed
the
add-more-AIR303-condition
branch
2 times, most recently
from
5573369 to
ebd06bb
Compare
Lee-W
changed the title
Lee-W
force-pushed
the
add-more-AIR303-condition
branch
from
ebd06bb to
debb3a2
Compare
Contributor
Author
|
This PR is now based on #17278 |
Lee-W
force-pushed
the
add-more-AIR303-condition
branch
2 times, most recently
from
76739c6 to
271f941
Compare
Contributor
Author
Contributor
Author
|
I guess we might need @dhruvmanila to confirm as well? |
Lee-W
changed the title
Contributor
|
I can override Dhruv's review if needed 😉 Can you fix the merge conflicts? Then I'll try to review today. |
Lee-W
force-pushed
the
add-more-AIR303-condition
branch
from
a925a8c to
d1a7740
Compare
Contributor
Author
|
Just updated! 🙏 |
ntBre
changed the title
airflow] Add missing AIR302 attribute check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
attribute check was missing in the previous implementation
e.g.
This PR adds this kind of check.
Test Plan
The test case has been added to the button of the existing test fixtures, confirmed to be correct and later reorgnaized