-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix livechat notifications for guest pool based routing #327
Conversation
PR to RC core addressing RocketChat#7796: RocketChat#10588 |
Observe RocketChat#10318 which adds even better notification title ;) |
@janrudolph can you actually test this? |
Verified on Mac OS with Chrome (to be repeated on Windows):
Not tested yet:
Additionally, I tested the following case:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing comments:
- Created a guest pool live chat with multiple agents. As per the test steps indicated, there was no notification appeared when the live chat was created. But the notification shows up, when the user write a message.
Scenarios Tested successfully on Mac:
|
lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This fixes #271 desktop notifications not being created if a live chat visitor created a room by sending the first message.
How to test
Remarks
room.t !== 'l'
) and implementing it there has a high re-use.