Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proxy] [Bug] No desktop notifications in livechat #10074 #271

Closed
janrudolph opened this issue Mar 9, 2018 · 2 comments · Fixed by #327
Closed

[Proxy] [Bug] No desktop notifications in livechat #10074 #271

janrudolph opened this issue Mar 9, 2018 · 2 comments · Fixed by #327

Comments

@janrudolph
Copy link

RocketChat#10074

@mrsimpson
Copy link
Member

This is somewhat something bigger - and messier.
The notifications seem to be handled / created in packages/rocketchat-lib/server/lib/sendNotificationsOnMessage.js

The core is a callback RocketChat.callbacks.add('afterSaveMessage', function(message, room, userId) {.
This callback contains a huge list of decisions when to notify whom. This is based on subscriptions.
In the case of livechat however, there are may be no subscriptions by the time a message is sent: The guest needs to be assigned to an agent first.
Thus, a similar logic needs to be implemented which adds a callback and either notifies the agent at hand or all agents online (in the guest pool mode).

Since RC seems to be working on an urgent fix, I'm not investigating further here

@mrsimpson mrsimpson modified the milestones: this-release, next-release Mar 26, 2018
@mrsimpson
Copy link
Member

Fixed in 0.64 RocketChat#10221 - can be cherry-picked:
upstream/no-desktop-notifications-in-livechat

@ghost ghost assigned mrsimpson Apr 25, 2018
@ghost ghost added the progress:working label Apr 25, 2018
@mrsimpson mrsimpson modified the milestones: 19, 19.1, 20 Apr 27, 2018
janrudolph added a commit that referenced this issue Jun 19, 2018
Fix livechat notifications for guest pool based routing
@ghost ghost removed the progress:working label Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants