Add Assert::ignore_status() for ignoring the command status #56

dsprenkels · 2017-10-17T10:01:24Z

Implements Assert::ignore_status(), which can be used to ignore whether a command exited successfully.

Fixes #23.

killercup · 2017-10-17T11:20:16Z

Thanks! Don't worry about the CI error, it's a known issue (see #50 (comment)).

r? @epage

Do we want the docs to mention that this will reset previously set assertions?

epage · 2017-10-17T14:05:24Z

Do we want the docs to mention that this will reset previously set assertions?

Might be nice because this doesn't just turn off the implicit succeeds() but also turns off the explicit .fails_with(code).

dsprenkels · 2017-10-17T15:26:39Z

I updated the PR with the new docstring.

Fixes #23

Namely, it removes any assertions that were previously made.

epage · 2017-10-17T21:49:07Z

bors: r+

56: Add Assert::ignore_status() for ignoring the command status r=epage a=dsprenkels Implements `Assert::ignore_status()`, which can be used to ignore whether a command exited successfully. Fixes #23.

bors · 2017-10-17T21:57:41Z

Build failed

continuous-integration/travis-ci/push

epage · 2017-10-17T22:26:46Z

Oh, right. Since nothing is lost with merging it anyways, I guess I'll do it manually.

dsprenkels changed the title ~~Add Assert::ignore_status for ignoring the command status~~ Add Assert::ignore_status() for ignoring the command status Oct 17, 2017

killercup requested a review from epage October 17, 2017 11:19

Daan Sprenkels added 2 commits October 17, 2017 17:35

Implement Assert::ignore_status

4de8e96

Fixes #23

Add note to ignore_status about existing asserts

95be0f1

Namely, it removes any assertions that were previously made.

bors bot added a commit that referenced this pull request Oct 17, 2017

Merge #56

7a7fbb5

56: Add Assert::ignore_status() for ignoring the command status r=epage a=dsprenkels Implements `Assert::ignore_status()`, which can be used to ignore whether a command exited successfully. Fixes #23.

epage merged commit a01f933 into assert-rs:master Oct 17, 2017

dsprenkels deleted the ignore_status branch October 17, 2017 22:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Assert::ignore_status() for ignoring the command status #56

Add Assert::ignore_status() for ignoring the command status #56

dsprenkels commented Oct 17, 2017 •

edited

Loading

killercup commented Oct 17, 2017

epage commented Oct 17, 2017

dsprenkels commented Oct 17, 2017

epage commented Oct 17, 2017

bors bot commented Oct 17, 2017

epage commented Oct 17, 2017

Add Assert::ignore_status() for ignoring the command status #56

Add Assert::ignore_status() for ignoring the command status #56

Conversation

dsprenkels commented Oct 17, 2017 • edited Loading

killercup commented Oct 17, 2017

epage commented Oct 17, 2017

dsprenkels commented Oct 17, 2017

epage commented Oct 17, 2017

bors bot commented Oct 17, 2017

Build failed

epage commented Oct 17, 2017

dsprenkels commented Oct 17, 2017 •

edited

Loading