fix: Remove unrelated output in main_binary #50
Conversation
|
I'm a bit baffled at the failure. stable and nightly succeeded. beta failed with |
| @@ -12,6 +12,9 @@ categories = ["development-tools::testing"] | |||
| keywords = ["cli", "testing", "assert"] | |||
| build = "build.rs" | |||
|
|
|||
| [[bin]] | |||
| name = "assert_fixture" | |||
There was a problem hiding this comment.
This binary is built only when building assert_cli itself, right? I.e., not when using it as a dependency. Is there any chance people might cargo install this? We could add a internal-tests feature and specify required-features for the bin. Or, can we add bins depending on cfg(test) in some other way?
There was a problem hiding this comment.
This binary is built only when building assert_cli itself, right? I.e., not when using it as a dependency.
I think I've heard depending on something doesn't pull in the bins.
Is there any chance people might cargo install this?
If they did, it wouldn't do them much good.
We could add a internal-tests feature and specify required-features for the bin. Or, can we add bins depending on cfg(test) in some other way?
The problem with relying on features is main_binary can't enable the feature.
| @@ -365,7 +368,7 @@ impl Assert { | |||
| /// ``` | |||
| pub fn unwrap(self) { | |||
| if let Err(err) = self.execute() { | |||
| panic!("{}", err); | |||
| panic!("{}", err.display_chain()); | |||
I've run into this with liquid also (beta, also depends on skeptic). At least on slack, no one else has run into this. I've not created a skeptic issue yet or checked on IRC. |
|
Reported this to Skeptic |
`clap` couldn't be used for command line arguments. I didn't want to add it as a dependency for clients, which meant it had to be optional. The problem is that `main_binary` and `cargo_binary` run with optional features enabled. Note: you cannot use `main_binary` or `cargo_binary` - With `Environment::empty` because the executable can't be found - In skeptic tests (like the README) because the working dir is changed
We use cargo run behind the scenes to run the main binary but that should only be an implementation detail. Fixes assert-rs#45
epage
force-pushed
the
fix/main_binary
branch
from
fae7c90
to
45a4aa6
Compare
|
Since there is no negative effect (loss of coverage, inability to make binaries, etc), going to go ahead and merge. |
@killercup - it was a skeptic bug due to change in how cargo beta produces Cargo.lock. It's now fixed in crates.io 0.13.2 (in a sane way not parsing Cargo.lock) |
To help in validating this, tests have been added for
main_binaryandcargo_binary.Fixed #45