Reacting to Razor changes - TagHelperOutput is writing to TextWriter instead of string. #2099
Conversation
ghost
added
the
|
/cc: @NTaylorMullen @dougbu |
| @@ -157,7 +159,7 @@ public TTagHelper CreateTagHelper<TTagHelper>() where TTagHelper : ITagHelper, n | |||
| /// </remarks> | |||
| public void StartWritingScope() | |||
| { | |||
| StartWritingScope(new StringWriter()); | |||
| StartWritingScope(new StringCollectionTextWriter(Encoding.UTF8)); | |||
There was a problem hiding this comment.
@dougbu do we have some app wide setting for encoding or is using UTF8 aok?
There was a problem hiding this comment.
I'm not aware of a system-wide setting. but in normal use RazorTextWriter is passed ViewContext.Writer.Encoding when created. AFAICT that value is always Encodings.UTF8EncodingWithoutBOM.
There was a problem hiding this comment.
Alternatively use the Encoding from the current TextWriter - StartWritingScope(new StringCollectionTextWriter(Output.Encoding));
|
⌚ |
| /// </summary> | ||
| /// <param name="writer">The <see cref="TextWriter"/> to which the output must be written to.</param> | ||
| /// <param name="copyableTextWriter">Contains the data which needs to be written to the output.</param> | ||
| public void WriteTo(TextWriter writer, ITextWriterCopyable copyableTextWriter) |
There was a problem hiding this comment.
as mentioned in aspnet/Razor#312, these methods must be named WriteLiteralTo because they perform no HTML encoding.
|
⌚ |
…instead of string.
| @@ -16,10 +15,10 @@ public class AutoLinkerTagHelper : TagHelper | |||
| var childContent = await context.GetChildContentAsync(); | |||
|
|
|||
| // Find Urls in the content and replace them with their anchor tag equivalent. | |||
| output.Content = Regex.Replace( | |||
| childContent, | |||
| output.Content.Append(Regex.Replace( | |||
|
@sornaks should do |
|
⌚ few more things, it's close |
| } | ||
| else | ||
| { | ||
| tagHelperContentWrapperTextWriter.Write(writer.ToString()); |
There was a problem hiding this comment.
should also special-case the StringCollectionTextWriter created in StartTagHelperWritingScope. the ToString() here loses many of the advantages of the Razor changes.
There was a problem hiding this comment.
What's the declared/runtime type of writer here? TextWriter.ToString() is not guaranteed to return the content - there can be trouble if the writer is replaceable.
We can leave this for a follow up as this assumption was present in the old code.
|
⌚ |
| /// <summary> | ||
| /// The <see cref="TagHelperContent"/> which is wrapped. | ||
| /// </summary> | ||
| public TagHelperContent Content { get; set; } |
There was a problem hiding this comment.
Advantage of having this get/set vs constructor + immutable? Are there cases where you would create the writer at one time and then the content later?
There was a problem hiding this comment.
No. Currently there are no cases like that. I can make this immutable.
|
Updated.. |
| } | ||
| else | ||
| { | ||
| selected = encodedValues.Contains((await context.GetChildContentAsync()).GetContent()); |
There was a problem hiding this comment.
two lines:
var childContent = await context.GetChildContentAsync();
selected = encodedValues.Contains(childContent.GetContent());
|
|
once
| /// <summary> | ||
| /// Writes an <see cref="ITextWriterCopyable"/> to the <paramref name="writer"/>. | ||
| /// </summary> | ||
| /// <param name="writer">The <see cref="TextWriter"/> to which the <paramref name="copyableTextWriter"/> is written.</param> |
|
|
|
Checked in. Thanks guys! 284eb9a |
aspnet/Razor#296