You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.
Extra additions to make this change more consumable:
ITextWriter should have an extension method to write on ITextWriter into another ITextWriter.
TagHelperContext's GetChildContentAsync should have an override to provide your own ITextWriter to write to.
The impact of this change will end up affecting all existing TagHelper's and will greatly affect how TagHelpers used (NOTE: Lots of impact in MVC to make this plausible).
The text was updated successfully, but these errors were encountered:
@sornaks: @yishaigalatzer, @DamianEdwards, @dougbu, and I felt like this is a pretty large feature that should make it in sooner rather than later (since it has huge impact). We can sit down together tomorrow or when you're ready to pair program the beginning parts of this to give you enough context on what needs to be done (lotssss of pieces to this 😄).
sornaks
changed the title
Change TagHelperOutput Content, PreContent and PostContent to all be ITextWriters to avoid large string allocations.
Change TagHelperOutput Content, PreContent and PostContent to all be TextWriters to avoid large string allocations.
Feb 19, 2015
This issue is the more concrete version of #295.
What should be done to
TagHelperOutput
:TagHelperOutput.PreContent
to beTagHelperOutput.PreContentWriter
.TagHelperOutput.Content
to beTagHelperOutput.ContentWriter
.TagHelperOutput.PostContent
to beTagHelperOutput.PostContentWriter
.All new property names here should be of type https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNet.Mvc.Core/Rendering/StringCollectionTextWriter.cs but exposed as
ITextWriter
. This means that type will need to be transitioned into theMicrosoft.AspNet.Razor.Runtime
repo.Extra additions to make this change more consumable:
ITextWriter
should have an extension method to write onITextWriter
into anotherITextWriter
.TagHelperContext
'sGetChildContentAsync
should have an override to provide your ownITextWriter
to write to.The impact of this change will end up affecting all existing
TagHelper
's and will greatly affect howTagHelper
s used (NOTE: Lots of impact in MVC to make this plausible).The text was updated successfully, but these errors were encountered: