Skip to content
This repository was archived by the owner on Oct 17, 2018. It is now read-only.

[1.0.4] Ignore assembly version when activating DataProtection types from string name #268

Merged
merged 1 commit into from
Aug 25, 2017

Conversation

natemcmaster
Copy link
Contributor

This is a port of #223 from the 2.0.0 release. It resolves an issue caused by activating types by type name. Type.GetType enforces the assembly version. This change strips assembly version before attempting to re-create DataProtection types.

Resolves #235

…ing name on .NET Framework

This is a port of #223 from the 2.0.0 release. It resolves an issue caused by activating types by type name. Type.GetType enforces the assembly version. This change strips assembly version before attempting to re-create DataProtection types.
Copy link
Contributor

@pakrym pakrym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works :)

@natemcmaster
Copy link
Contributor Author

Automated tests pass. I'm building a repro to manually verify it.

@natemcmaster
Copy link
Contributor Author

Yup, it works. Here's a verification app for anyone else that wants to give it a go. https://gist.github.com/natemcmaster/7dfb37813a3024f228971ea89188dfde

@natemcmaster natemcmaster merged commit 02f122a into rel/1.0.4 Aug 25, 2017
@natemcmaster natemcmaster deleted the namc/type-activation-10 branch August 25, 2017 19:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants