This repository has been archived by the owner on Oct 17, 2018. It is now read-only.
Ignore assembly version when activating DataProtection types from string name #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakrym
reviewed
Apr 20, 2017
| @@ -27,6 +27,8 @@ public SimpleActivator(IServiceProvider services) | |||
|
|
|||
| public virtual object CreateInstance(Type expectedBaseType, string implementationTypeName) | |||
| { | |||
| implementationTypeName = RemoveVersionFromAssemblyName(implementationTypeName); | |||
pakrym
reviewed
Apr 20, 2017
|
|
||
| private static string RemoveVersionFromAssemblyName(string typeName) | ||
| { | ||
| var idx = typeName.IndexOf(','); |
There was a problem hiding this comment.
Would this fail on generic types?
There was a problem hiding this comment.
I don't think so. I'll add a test to make sure
pakrym
reviewed
Apr 20, 2017
| } | ||
|
|
||
| // type name includes assembly name | ||
| var assemblyName = typeName.Substring(idx + 1); |
There was a problem hiding this comment.
This needs to be enabled only for predefined list of our assemblies.
There was a problem hiding this comment.
Should it be a specific list or is AssemblyName.StartsWith("Microsoft.AspNetCore") ok?
There was a problem hiding this comment.
Let's do just DataProtection assemblies.
pakrym
reviewed
Apr 20, 2017
| using Microsoft.AspNetCore.DataProtection.Internal; | ||
| using Microsoft.Extensions.DependencyInjection; | ||
| using Moq; | ||
| using Xunit; | ||
|
|
||
| namespace Microsoft.AspNetCore.DataProtection | ||
| { | ||
| public class ActivatorTests | ||
| public class ActivatorTests : MarshalByRefObject |
There was a problem hiding this comment.
Required to make this work: AppDomain.CreateInstanceAndUnwrap.
…f type name is a generic
|
🆙 📅 |
natemcmaster
changed the title
|
Btw, I verified the end-to-end scenario manually using this project file and the code provided in #187 <Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net461</TargetFramework>
</PropertyGroup>
<ItemGroup>
<!--<PackageReference Include="Microsoft.AspNetCore.DataProtection.Extensions" Version="2.0.0-*"/>-->
<ProjectReference Include="../../src/Microsoft.AspNetCore.DataProtection.Extensions/Microsoft.AspNetCore.DataProtection.Extensions.csproj"/>
</ItemGroup>
</Project> |
|
@natemcmaster thanks for fixing this bug! 👏 |
|
Add a test to verify that version is not striped from non asp.net core assemblies. |
|
🆙 📅 |
pakrym
approved these changes
Apr 25, 2017
This was referenced May 18, 2017
Merged
natemcmaster
pushed a commit
that referenced
this pull request
Aug 25, 2017
…ing name on .NET Framework This is a port of #223 from the 2.0.0 release. It resolves an issue caused by activating types by type name. Type.GetType enforces the assembly version. This change strips assembly version before attempting to re-create DataProtection types.
natemcmaster
pushed a commit
that referenced
this pull request
Aug 25, 2017
…ing name on .NET Framework This is a port of #223 from the 2.0.0 release. It resolves an issue caused by activating types by type name. Type.GetType enforces the assembly version. This change strips assembly version before attempting to re-create DataProtection types.
natemcmaster
pushed a commit
that referenced
this pull request
Aug 25, 2017
…ing on .NET Framework. This is a port of #223 from the 2.0.0 release. It resolves an issue caused by activating types by type name. Type.GetType enforces the assembly version. This change strips assembly version before attempting to re-create DataProtection types.
natemcmaster
pushed a commit
that referenced
this pull request
Aug 28, 2017
…ing on .NET Framework. This is a port of #223 from the 2.0.0 release. It resolves an issue caused by activating types by type name. Type.GetType enforces the assembly version. This change strips assembly version before attempting to re-create DataProtection types.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #187 by ignoring assembly version in the code the rehydrates types from strings.
Incidental fixups: