Matrix operators #398

WhiteBlackGoose · 2021-04-29T09:51:21Z

|+, |-, |*, |/, |** will return an instance of Matrix, no matter what. Any feedback on the API?

codecov-commenter · 2021-04-29T10:15:46Z

Codecov Report

Merging #398 (78fd180) into master (11e738f) will decrease coverage by 0.03%.
The diff coverage is 82.60%.

@@            Coverage Diff             @@
##           master     #398      +/-   ##
==========================================
- Coverage   80.61%   80.57%   -0.04%     
==========================================
  Files         145      145              
  Lines       12451    12512      +61     
  Branches     1676     1704      +28     
==========================================
+ Hits        10037    10082      +45     
- Misses       1902     1919      +17     
+ Partials      512      511       -1

Impacted Files	Coverage Δ
Sources/AngouriMath/Convenience/MathS.cs	`68.22% <ø> (+0.27%)`	⬆️
...nuous/Evaluation.Continuous.Arithmetics.Classes.cs	`84.80% <ø> (+1.99%)`	⬆️
...rces/AngouriMath/Core/Entity/Omni/Entity.Matrix.cs	`79.39% <82.60%> (+0.42%)`	⬆️
...iMath/Core/Exceptions/UserInputInvalidException.cs	`69.23% <0.00%> (-7.70%)`	⬇️
...inuous/Solvers/EquationSolver/ExponentialSolver.cs	`92.64% <0.00%> (-2.95%)`	⬇️
...Solvers/EquationSolver/AnalyticalEquationSolver.cs	`81.25% <0.00%> (-2.09%)`	⬇️
Sources/AngouriMath/Core/Parser.cs	`88.00% <0.00%> (+6.42%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11e738f...78fd180. Read the comment docs.

WhiteBlackGoose · 2021-05-05T20:07:19Z

Moving PeterONumbers from 1.7.4 to 1.8 broke a couple of tests, 🦆

WhiteBlackGoose · 2021-05-07T12:03:32Z

Sources/Tests/UnitTests/Core/NumericDigits.cs

        [Fact] public void PowI_2() => Test(Pow(i, 2), "-1");
        [Fact] public void PowI_I() => Test(Pow(i, i), "0.2078795763507619085469556198349787700338778416317696080751358830554198772854821397886002778654260353");
        [Fact] public void Pow0D5M0D8I_0D5() => Test(Pow(0.5m-0.8m*i, 0.5m), "0.8495287261787150364907695626370349126367049237188233590072351305588742785045041120988684216395800850 - 0.4708492928770629369416080841473292873459093837847060526082076263776372676635818831502937646218684434i");
        [Fact] public void Sqrt0D5M0D8I() => Test(Sqrt(0.5m-0.8m*i), "0.8495287261787150364907695626370349126367049237188233590072351305588742785045041120988684216395800853 - 0.4708492928770629369416080841473292873459093837847060526082076263776372676635818831502937646218684426i");
-        [Fact] public void Pow3P2I_3M2I() => Test(Pow(3+2*i,3-2*i), "105.7489754858859776057429151808913270583911891854438642007164406579203854865458413612560669739008053 - 109.0885464095191985068230453514141449073149001480712525014939233398460315014292268679635166428957469i");


This all stuff... due to some precision regression in PeterO.Numbers 1.8.0 (as compared to 1.7.4, the previous version). Should be reported to their repo.

Then is there a reason to update?

Just because updated is better than non-updated?

Happypig375 · 2021-05-07T16:08:48Z

Sources/Tests/UnitTests/Algebra/MatrixTest.cs

+        public void TestInverseWithGT101Issue400(string matrixRaw)
+        {
+            Matrix a = matrixRaw;
+            var inverse = a.Inverse!;


Make a ThrowWhenNull as specified under https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/attributes/nullable-analysis#specify-post-conditions-maybenull-and-notnull

ThrowWhenNull is an attribute for return though. null is a perfectly valid return from Inverse. So I'll just make a Assert.NotNull (I actually thought that ! throws an exception!)

ThrowWhenNull is not an attribute, and [NotNull] can be specified at the argument position as documented.

You can check, now it's AsNotNull<>.

AngouriMath/Sources/Tests/UnitTests/TestUtils.cs

Lines 18 to 22 in 4043999

public static T AsNotNull<T>(T? value)

{

Assert.NotNull(value);

return value!;

}

Happypig375 · 2021-05-07T16:09:11Z

Sources/Tests/UnitTests/Core/NumericDigits.cs

        [Fact] public void PowI_2() => Test(Pow(i, 2), "-1");
        [Fact] public void PowI_I() => Test(Pow(i, i), "0.2078795763507619085469556198349787700338778416317696080751358830554198772854821397886002778654260353");
        [Fact] public void Pow0D5M0D8I_0D5() => Test(Pow(0.5m-0.8m*i, 0.5m), "0.8495287261787150364907695626370349126367049237188233590072351305588742785045041120988684216395800850 - 0.4708492928770629369416080841473292873459093837847060526082076263776372676635818831502937646218684434i");
        [Fact] public void Sqrt0D5M0D8I() => Test(Sqrt(0.5m-0.8m*i), "0.8495287261787150364907695626370349126367049237188233590072351305588742785045041120988684216395800853 - 0.4708492928770629369416080841473292873459093837847060526082076263776372676635818831502937646218684426i");
-        [Fact] public void Pow3P2I_3M2I() => Test(Pow(3+2*i,3-2*i), "105.7489754858859776057429151808913270583911891854438642007164406579203854865458413612560669739008053 - 109.0885464095191985068230453514141449073149001480712525014939233398460315014292268679635166428957469i");


Then is there a reason to update?

Happypig375 · 2021-05-07T16:10:59Z

Sources/Tests/UnitTests/Algebra/MatrixTest.cs

                .Substitute("B", 2)
                .Substitute("C", 3)
                .Substitute("D", 4);
-            Assert.Equal(-2, v.EvalNumerical());
+            Assert.NotNull(v);
+            Assert.Equal(-2, v!.EvalNumerical());


Make a ThrowWhenNull as specified under https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/attributes/nullable-analysis#specify-post-conditions-maybenull-and-notnull

Happypig375 · 2021-05-07T16:11:50Z

Sources/AngouriMath/Core/Entity/Omni/Entity.Matrix.cs

+            public Entity? Determinant => determinant.GetValue(
+                static @this => 
+                {
+                    if ([email protected]) 


Shouldn't this check be in GenericTensor?

Yes, but it is exception-based. Here we want to return a null in that case. (sure we can catch exceptions, but... quack. Maybe we will after the GenericTensorBaseException implemented)

Then don't throw exceptions in GenericTensor!

asc-community/GenericTensor#23

Happypig375 · 2021-05-07T16:12:21Z

Sources/AngouriMath/Core/Entity/Omni/Entity.Matrix.cs

+                if ([email protected])
+                    return null;
+                if (@this.Determinant is null)
+                    return null;
+                if (@this.Determinant == 0)


Shouldn't these checks be in GenericTensor?

Same thing, we want to return null to avoid an exception

Then don't throw exceptions in GenericTensor!

Hmmmmmmmmmmmmmmmmmmmmmmmmmmm. We can have 1.0.1-noexcept package for it. Since if you remember, there's ALLOW_EXCEPTION flag.

@MomoDeve would love this

Happypig375 · 2021-05-07T16:18:17Z

Sources/Tests/FSharpWrapperUnitTests/MatrixOperatorsTest.fs

+(*
+
+ Matrix and matrix operators
+
+*)


This can be just a single-line comment

I was trying to make it "bold" :).

https://textfancy.com/font-converter/

Sources/Tests/FSharpWrapperUnitTests/MatrixOperatorsTest.fs

Sources/Wrappers/AngouriMath.FSharp/MatrixOperators.fs

Happypig375 · 2021-05-07T16:25:04Z

Sources/Tests/FSharpWrapperUnitTests/MatrixOperatorsTest.fs

+(*
+
+Matrix and scalar operators
+Scalar and matrix operators
+
+*)


Can be two single-line comments

Operators added; adding tests

75c7aa8

WhiteBlackGoose added Proposal Contribute to the project by proposing some improvements Opinions wanted We are interested in your opinion about the topic labels Apr 29, 2021

WhiteBlackGoose linked an issue Apr 29, 2021 that may be closed by this pull request

Matrix operators #395

Closed

Tests fixed & added

fb38e96

WhiteBlackGoose added the Area: F# The issue is related to the AngouriMath.FSharp package label May 2, 2021

Temporary revert

26150cf

WhiteBlackGoose linked an issue May 5, 2021 that may be closed by this pull request

Unexpected inverse #400

Closed

#400; moved to GT 1.0.1 with the fixed problem

ee4a769

#404

7d33b51

WhiteBlackGoose linked an issue May 6, 2021 that may be closed by this pull request

No exception for Adjugate and Inverse #404

Closed

WhiteBlackGoose added 3 commits May 7, 2021 11:20

Nullables fixed

ab73ffa

No more division in inner simplification. Tests removed

a8a4441

Tests adapted to Numbers 1.8.0

4a2b2e9

WhiteBlackGoose commented May 7, 2021

View reviewed changes

WhiteBlackGoose marked this pull request as ready for review May 7, 2021 15:52

WhiteBlackGoose requested a review from Happypig375 May 7, 2021 15:55

Happypig375 requested changes May 7, 2021

View reviewed changes

WhiteBlackGoose added 4 commits May 7, 2021 20:03

Minor changes

ba2651f

Division reverted (because it is for matrix + scalar)

d45a7c5

Typo

4043999

Moved to GT 1.0.3; errors for single-element matrices fixed

78fd180

WhiteBlackGoose merged commit ce56555 into master May 8, 2021

WhiteBlackGoose deleted the matrix-operators branch May 30, 2021 10:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Matrix operators #398

Matrix operators #398

WhiteBlackGoose commented Apr 29, 2021

codecov-commenter commented Apr 29, 2021 •

edited

Loading

WhiteBlackGoose commented May 5, 2021

WhiteBlackGoose May 7, 2021

Happypig375 May 7, 2021

WhiteBlackGoose May 7, 2021

Happypig375 May 7, 2021

WhiteBlackGoose May 7, 2021

Happypig375 May 7, 2021

WhiteBlackGoose May 7, 2021

Happypig375 May 7, 2021

Happypig375 May 7, 2021

Happypig375 May 7, 2021

WhiteBlackGoose May 7, 2021 •

edited

Loading

Happypig375 May 7, 2021

WhiteBlackGoose May 8, 2021

Happypig375 May 7, 2021

WhiteBlackGoose May 7, 2021

Happypig375 May 7, 2021

WhiteBlackGoose May 7, 2021

WhiteBlackGoose May 7, 2021

Happypig375 May 7, 2021

WhiteBlackGoose May 7, 2021

Happypig375 May 7, 2021

WhiteBlackGoose May 7, 2021

Happypig375 May 7, 2021

	public static T AsNotNull<T>(T? value)
	{
	Assert.NotNull(value);
	return value!;
	}

Matrix operators #398

Matrix operators #398

Conversation

WhiteBlackGoose commented Apr 29, 2021

codecov-commenter commented Apr 29, 2021 • edited Loading

Codecov Report

WhiteBlackGoose commented May 5, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

WhiteBlackGoose May 7, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-commenter commented Apr 29, 2021 •

edited

Loading

WhiteBlackGoose May 7, 2021 •

edited

Loading