Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No exception for Adjugate and Inverse #404

Closed
WhiteBlackGoose opened this issue May 5, 2021 · 2 comments · Fixed by #398
Closed

No exception for Adjugate and Inverse #404

WhiteBlackGoose opened this issue May 5, 2021 · 2 comments · Fixed by #398
Labels
Accepted For proposals, which were approved and will be implemented Proposal Contribute to the project by proposing some improvements up-for-grabs Issues which don't require internal knowledge to close so can be completed by outside contributors
Milestone
1.3

Comments

@WhiteBlackGoose
Copy link
Member

Adjugate should have type Matrix? and not throw an exception (it can, if the matrix is non-square). There should be no ComputeInverse(), instead there should be Invsere of type Matrix?.
@WhiteBlackGoose WhiteBlackGoose added Proposal Contribute to the project by proposing some improvements Accepted For proposals, which were approved and will be implemented labels May 5, 2021
@WhiteBlackGoose WhiteBlackGoose added this to the 1.3 milestone May 5, 2021
@WhiteBlackGoose WhiteBlackGoose added the up-for-grabs Issues which don't require internal knowledge to close so can be completed by outside contributors label May 5, 2021
@Happypig375
Copy link
Member

Invsere?

@WhiteBlackGoose
Copy link
Member Author

🦆

WhiteBlackGoose added a commit that referenced this issue May 6, 2021
@WhiteBlackGoose
#404
7d33b51
@WhiteBlackGoose WhiteBlackGoose linked a pull request May 6, 2021 that will close this issue
Matrix operators #398
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted For proposals, which were approved and will be implemented Proposal Contribute to the project by proposing some improvements up-for-grabs Issues which don't require internal knowledge to close so can be completed by outside contributors
Projects
None yet
Milestone
1.3
Development

Successfully merging a pull request may close this issue.

Matrix operators asc-community/AngouriMath
2 participants
@Happypig375 @WhiteBlackGoose